Compile errors about mod-playerbots HOT 12 CLOSED

Thank you for report this. I'm glad you've found a temporarily solution that is working for you. Could you please share some details of your build environment? (OS version, g++ version, boost version, etc.) I will try to resolve this error so others are not having same trouble.

from mod-playerbots.

I get this error to. I am not sure it is a good idea ever to use comparison like == or != on vectorial objects that contains floats as floats will almost always be different on the last decimals due to the rounding errors of how they work in hardware. A better comparisson would be to say "vector A" and vector B are equal iff they differ by some small epsillon. I am pretty sure that that functionality is already implemented somewhere in the azerothcore.

from mod-playerbots.

azerothcore-wotlk/modules/mod-playerbots/src/strategy/actions/MovementActions.cpp:455:82: fatal error: use of overloaded operator '!=' is ambiguous (with operand types 'WorldPosition' and 'WorldPosition')
if (sPlayerbotAIConfig->hasLog("bot_movement.csv") && lastMove.lastMoveShort != movePosition)

There is another line in MovementActions.cpp

from mod-playerbots.

azerothcore-wotlk/modules/mod-playerbots/src/strategy/actions/MovementActions.cpp:455:82: fatal error: use of overloaded operator '!=' is ambiguous (with operand types 'WorldPosition' and 'WorldPosition') if (sPlayerbotAIConfig->hasLog("bot_movement.csv") && lastMove.lastMoveShort != movePosition)

There is another line in MovementActions.cpp

Confirmed, changed to the same line above and it compiled.

from mod-playerbots.

I have used hack way to make it compiled first, but I'm sure it's not supposed to be a perfect solution.

if (telePos && telePos != movePosition) to if (telePos && not (telePos == movePostion))

from mod-playerbots.

I'm on Ubuntu 20.04, Clang version 10.0.0, cmake version 3.16, boost version 1.71
Ubuntu is a VM running on a Synology NAS.

from mod-playerbots.

I think you need cmake 3.18 and clang 11

from mod-playerbots.

I think you need cmake 3.18 and clang 11

ok, I will try them

from mod-playerbots.

I get this error to. I am not sure it is a good idea ever to use comparison like == or != on vectorial objects that contains floats as floats will almost always be different on the last decimals due to the rounding errors of how they work in hardware. A better comparisson would be to say "vector A" and vector B are equal iff they differ by some small epsillon. I am pretty sure that that functionality is already implemented somewhere in the azerothcore.

Thank you for the helpful suggestion. I will find time to fix this comparison.

from mod-playerbots.

I have changed this line to more secure in 90be77b. Please let me know if this resolve the issue for you.

from mod-playerbots.

Thank you again for finding these comparisons. I have fixed this other one in 7e2a87a.

from mod-playerbots.

Thank you again for finding these comparisons. I have fixed this other one in 7e2a87a.

Thank you for your good working, I think this issue can be closed.

from mod-playerbots.