Git Product home page Git Product logo

Comments (3)

zeux avatar zeux commented on July 17, 2024

Are you building volk using CMake?

from volk.

multisample avatar multisample commented on July 17, 2024

no, so i guess that answers that :)

from volk.

zeux avatar zeux commented on July 17, 2024

I should have been more specific I guess :)

If you're building volk as part of your project, I'd recommend setting VK_ENABLE_BETA_EXTENSIONS on the entire project.
If you're building volk as a separate static library, through CMake or otherwise, you should add the define there - with CMake it's possible using VOLK_STATIC_DEFINES variable.

The reason why it's incorrect to just define this in volk.c is that it would introduce new fields into VolkDeviceTable interface, so for people who use that interface and don't use beta extensions there's going to be issues because the layout of the struct will be inconsistent.

So the defines need to be set consistently between the header and the implementation, and the best way to do that is to set them externally.

from volk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.