`extract_from_url` URL parameter parsing breaks about collective.sendaspdf HOT 8 CLOSED

I did a quick fix and have released version 2.10.

Using parse_qs would indeed be nicer. I did a quick stab at that, but you quickly run into irritating differences between Python 2.4 (which we still want to support as we are using this on a Plone 3 site) and more recent pythons. I'm going to leave it for the moment at: pull requests welcome.

from collective.sendaspdf.

Hehe, I knew it wouldn't be as easy as swapping in parse_qs :-S

from collective.sendaspdf.

Note that the url-encoded string has no colon but still fails. I don't know if it's practical to extend the regex to cater for all url-encoding.

from collective.sendaspdf.

I added a + also (jean@0779672), don't know what else will still break ..

from collective.sendaspdf.

That is meant as a literal +, right? Then it should probably be backslash-escaped, because it is used in a regular expression.

from collective.sendaspdf.

That is meant as a literal +, right? Then it should probably be
backslash-escaped, because it is used in a regular expression.

Hmm probably yes though it seemed to work locally.
Probably better to ignore this for now until there's time to look at
it properly.

jean . .. .... //\oo///\

from collective.sendaspdf.

I still think i don't belong in this mail conversation...
i am Maurits van Mierlo NOT van Rees.

On 29 Jan 2014, at 10:29, Maurits van Rees [email protected] wrote:

That is meant as a literal +, right? Then it should probably be backslash-escaped, because it is used in a regular expression.

—
Reply to this email directly or view it on GitHub.

from collective.sendaspdf.

Sorry about that, Maurits. I don't see you mentioned in this issue though, so not sure how that happened, although I remember it happened in one of the issues.

I think only you can change anything about that currently. Near the bottom of this page you can unsubscribe from notifications for this issue. Near the top of the page you can ignore any notifications for this repository.

from collective.sendaspdf.