Buffer overflow in zts_get_ipv4_address? about libzt HOT 2 CLOSED

Correct. That method has been replaced in the latest version in dev, with zts_get_address().

You can use this more generalized version below until I merge stuff back into master.

void zts_get_address(const uint64_t nwid, struct sockaddr_storage *addr, const size_t addrlen)
{
	if (!zt1Service) {
		return;
	}
	VirtualTap *tap = getTapByNWID(nwid);
	if (tap && tap->_ips.size()) {
		for (size_t i=0; i<tap->_ips.size(); i++) {
			if (tap->_ips[i].isV4()) {
				memcpy(addr, &(tap->_ips[i]), addrlen);
				return;
			}
		}
	}
}

from libzt.

Another note, this function will only return the first address assignment found for this node on the given network. For the vast majority of cases this is desired but I plan to introduce an extended version of this function that will return an array of addresses. Probably when somebody asks for it.

from libzt.