Git Product home page Git Product logo

Comments (10)

ZeroQI avatar ZeroQI commented on September 26, 2024

https://support.plex.tv/hc/en-us/articles/200220717-Local-Media-Assets-TV-Shows
If we use local media assets and put it before HAMA, it should load local meta first.
We can test, and if works , then using that would make more sense i believe

Media stubs are loaded in scanner and generate dummy entries, like multi episode files

from hama.bundle.

EndOfLine369 avatar EndOfLine369 commented on September 26, 2024

Ok, misunderstood media stubs so ignore that.

It already has that agent as second in the agent listing.

image

So your saying move it to be first?

from hama.bundle.

ZeroQI avatar ZeroQI commented on September 26, 2024

Yes indeed. It is mentionned in the scanner readme (took me 10 minutes to find back, don't feel bad)

###Local metadata
It is supported but through "local media assets" agent, add it and and put it before HAMA in the priority order.

https://support.plex.tv/hc/en-us/articles/200220717-Local-Media-Assets-TV-Shows

Data type Source Comment
fanart art/backdrop/background/fanart-1.ext -1 can be ommited (same level as Video TS)
Serie poster Serie folder: Show name-1/folder/poster/show.ext (jpg, jpeg, png, tbn)
Season poster Season folder: Season01a.ext (jpg, jpeg, png, tbn)
Banner banner/banner-1.jpg
Theme song theme.mp3
Subtitles file name.ext (srt, smi, ssa, ass)
Plexignore files .plexignore

from hama.bundle.

EndOfLine369 avatar EndOfLine369 commented on September 26, 2024

Is there any way or do we want to have it automatically put the LMA agent above HAMA? I would think there should be some way as TMDB/TVDB in Plex have multiple agents in their listings.

image

from hama.bundle.

ZeroQI avatar ZeroQI commented on September 26, 2024

maybe we can put local media agent first in the code below.
The agents need to share the guid in mentionned secondary agents but in that case it's irrelevant. users can disable and change priority on that very window.

class HamaTVAgent(Agent.TV_Shows, HamaCommonAgent):
  name, primary_provider, fallback_agent, contributes_to, languages, accepts_from = ('HamaTV', True, False, None, [Locale.Language.English,], ['com.plexapp.agents.localmedia'] ) #, 'com.plexapp.agents.opensubtitles'

I believe you are right in implying local media take precedence. if they don't want a poster in hte folder as main poster, they should delete/move it to Extras

On a separate note, theme songs, I believe the metadata id changes need small change (tvdbid for metadata.id):
self.metadata_download (metadata.themes, THEME_URL % tvdbid, 1, "Plex/"+metadata.id+".mp3")

### Plex - Plex Theme song - https://plexapp.zendesk.com/hc/en-us/articles/201178657-Current-TV-Themes ###
      if THEME_URL % tvdbid in metadata.themes:  Log.Info("Theme song - already added")
      elif Prefs['GetPlexThemes']:
        self.metadata_download (metadata.themes, THEME_URL % tvdbid, 1, "Plex/%s.mp3" % tvdbid)
        if not THEME_URL % tvdbid in metadata.themes:  error_log['Plex themes missing'].append("tvdbid: %s | Title: '%s' | %s" % (WEB_LINK % (TVDB_SERIE_URL % tvdbid, tvdbid), tvdbtitle, WEB_LINK % ("mailto:[email protected]?cc=&subject=Missing%%20theme%%20song%%20-%%20'%s%%20-%%20%s.mp3'" % (tvdbtitle, tvdbid), 'Upload')))

from hama.bundle.

EndOfLine369 avatar EndOfLine369 commented on September 26, 2024

Just a random thought that came to mind as I don't know how multiple agents work with each other. Would putting the 'localmedia' agent first cause issues in meatdata id assignment? as 'localmedia' would put an id and skip HAMA search for id assignment?

Re theme songs, makes sense. As Plex has for tvdbid which means we actually have duplicate mp3 files based on the 'metadata.id' named files for Anidb series under the same tvdb id. So good call on the change.

from hama.bundle.

ZeroQI avatar ZeroQI commented on September 26, 2024

We need a mechanism for anidb as there is a song per season. Wanted a 30s
theme song archive...

The primary agent give the id
The secondary agent other stuff. Putting it first in the list should make
it favor local files as metadata

Sorry fir the many errors. Am surprised at times i managed to do the
scanner for so long alone... i learnt few things so thanks.

I saw you forked the rom browser...
Did some coding but nothing actionable with mane offline flat files...

On 29 Jul 2016 19:00, "EndOfLine369" [email protected] wrote:

Just a random thought that came to mind as I don't know how multiple
agents work with each other. Would putting the 'localmedia' agent first
cause issues in meatdata id assignment? as 'localmedia' would put an id and
skip HAMA search for id assignment?

Re theme songs, makes sense. As Plex has for tvdbid which means we
actually have duplicate mp3 files based on the 'metadata.id' named files
for Anidb series under the same tvdb id. So good call on the change.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#67 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE7LZbFwsd-0skC61B1Vgtnt1wPjGWr_ks5qaj-xgaJpZM4JV_Ey
.

from hama.bundle.

EndOfLine369 avatar EndOfLine369 commented on September 26, 2024

ok, so no matter what the order, as HAMA is the primary (even if 20th in order) it still assigns the id (meaning is the search source). good to know.

forked it to mainly to bring it into view to remind myself to take a look

from hama.bundle.

ZeroQI avatar ZeroQI commented on September 26, 2024

I think since this exists, no need to implement ourselves...
Is it working as expected ? If so, shall we close ?

from hama.bundle.

ZeroQI avatar ZeroQI commented on September 26, 2024

@EndOfLine369 Is it working as expected ? If so, shall we close this issue ticket ?

from hama.bundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.