Git Product home page Git Product logo

Comments (13)

ZeroQI avatar ZeroQI commented on September 26, 2024

Check if scudlee's mapping is in the xml in the partition data folder.
Check if 'TVDB/72745.xml' have ep descriptions
tvdb_table: [] so prob outdated info in cache wasn't refreshed

from hama.bundle.

sven-7 avatar sven-7 commented on September 26, 2024

TVDB/72745.xml does have the ep descriptions.

The mapping is in anime-list-master.xml as well.

from hama.bundle.

EndOfLine369 avatar EndOfLine369 commented on September 26, 2024

Looks like the issue is with missing tvdb data. Episodes 1-44&48 are all missing their 'Absolute Number' defined. Once you update tvdb and the url cache expires, you summaries should show.

2016-06-08 17:38:42,483 (138c) : ERROR (logkit:22) - An abs number has been found on ep (s1e45) after starting to manually place our own abs numbers
2016-06-08 17:38:42,483 (138c) : INFO (logkit:16) - abs_manual_placement_worked: 'False', abs_manual_placement_info: '['s1e1 = abs 1', 's1e2 = abs 2', 's1e3 = abs 3', 's1e4 = abs 4', 's1e5 = abs 5', 's1e6 = abs 6', 's1e7 = abs 7', 's1e8 = abs 8', 's1e9 = abs 9', 's1e10 = abs 10', 's1e11 = abs 11', 's1e12 = abs 12', 's1e13 = abs 13', 's1e14 = abs 14', 's1e15 = abs 15', 's1e16 = abs 16', 's1e17 = abs 17', 's1e18 = abs 18', 's1e19 = abs 19', 's1e20 = abs 20', 's1e21 = abs 21', 's1e22 = abs 22', 's1e23 = abs 23', 's1e24 = abs 24', 's1e25 = abs 25', 's1e26 = abs 26', 's1e27 = abs 27', 's1e28 = abs 28', 's1e29 = abs 29', 's1e30 = abs 30', 's1e31 = abs 31', 's1e32 = abs 32', 's1e33 = abs 33', 's1e34 = abs 34', 's1e35 = abs 35', 's1e36 = abs 36', 's1e37 = abs 37', 's1e38 = abs 38', 's1e39 = abs 39', 's1e40 = abs 40', 's1e41 = abs 41', 's1e42 = abs 42', 's1e43 = abs 43', 's1e44 = abs 44']'
2016-06-08 17:38:42,483 (138c) : DEBUG (logkit:13) - Update() - TVDB - tvdb_table: []

from hama.bundle.

sven-7 avatar sven-7 commented on September 26, 2024

I had this issue with ReBoot the other day -- I noticed it was getting hung up because TVDB had no absolute. I went to TVDB and added them for ReBoot -- then no problem. This show, however, is locked. Can't be added so easily.

from hama.bundle.

sven-7 avatar sven-7 commented on September 26, 2024

This is considered season 0 by TVDB. Long story, I tried to have them add it as a separate series, but because it's an OAV, they wouldn't. AniDB has it and ScudLee mapped it where they did the specials, but because Season 1 for Cyborg 009 (2001) doesn't have absolute, it's messing up.

from hama.bundle.

ZeroQI avatar ZeroQI commented on September 26, 2024

http://thetvdb.com/?tab=season&seriesid=72745&seasonid=20210&lid=7 - Don't think you can have absolute numbers for specials

anidb has ep 1-3 which is mapped to ep s0e3-5 which have summaries in
http://thetvdb.com/api/A27AD9BE0DA63333/series/72745/all/en.xml
logs have empty tvdb_table so we should be able to correct that.

Update() - TVDB - tvdb_table: []
TVDB mapping episode summary - anidb_ep: 's1e1', tvdb_ep: 's0e3', season: '1', epNumVal: '1', defaulttvdbseason: '0', title: 'Volume 1', summary: ''
TVDB mapping episode summary - anidb_ep: 's1e2', tvdb_ep: 's0e4', season: '1', epNumVal: '2', defaulttvdbseason: '0', title: 'Volume 2', summary: ''
TVDB mapping episode summary - anidb_ep: 's1e3', tvdb_ep: 's0e5', season: '1', epNumVal: '3', defaulttvdbseason: '0', title: 'Volume 3', summary: ''
2016-06-08 17:38:47,035 (138c) : DEBUG (logkit:13) - Update() - AniDB episode title: 'Volume 2'*

from hama.bundle.

EndOfLine369 avatar EndOfLine369 commented on September 26, 2024

@ZeroQI, Was thinking about this and your post gave me an idea to make this simple.
We could add a defaulttvdbseason check to see if we need to mess with abs numbers. As we only mess with them for non season zero episodes.

FROM:
        ### TVDB - Build 'tvdb_table' ###
        abs_manual_placement_worked = True
        if max(map(int, media.seasons.keys()))==1 or metadata.id.startswith("tvdb3-"):

TO:
        ### TVDB - Build 'tvdb_table' ###
        abs_manual_placement_worked = True
        if defaulttvdbseason != "0" and max(map(int, media.seasons.keys()))==1 or metadata.id.startswith("tvdb3-"):

Thought?

from hama.bundle.

ZeroQI avatar ZeroQI commented on September 26, 2024

@EndOfLine369: simple yet beautiful. I like it. Does it work giving episode summary for the serie above ?

from hama.bundle.

EndOfLine369 avatar EndOfLine369 commented on September 26, 2024

It should. You showed above that the three episodes are all defaulttvdbseason: '0' on their mapping episode summary post. And this variable is only set when 'anidb' id so should not interfere with other ids as its a != "0".

from hama.bundle.

EndOfLine369 avatar EndOfLine369 commented on September 26, 2024

Changed the code line to:
if defaulttvdbseason != "0" and max(map(int, media.seasons.keys()))==1 or metadata.id.startswith("tvdb3-"):

And Hama went from:

2016-06-10 11:37:37,618 (-b5ef470) :  DEBUG (networking:166) - Requesting 'http://thetvdb.com/api/A27AD9BE0DA63333/series/72745/all/en.xml'
2016-06-10 11:37:38,108 (-b5ef470) :  ERROR (__init__:651) - An abs number has been found on ep (s1e45) after starting to manually place our own abs numbers
2016-06-10 11:37:38,109 (-b5ef470) :  INFO (__init__:651) - abs_manual_placement_worked: 'False', abs_manual_placement_info: '['s1e1 = abs 1', 's1e2 = abs 2', 's1e3 = abs 3', 's1e4 = abs 4', 's1e5 = abs 5', 's1e6 = abs 6', 's1e7 = abs 7', 's1e8 = abs 8', 's1e9 = abs 9', 's1e10 = abs 10', 's1e11 = abs 11', 's1e12 = abs 12', 's1e13 = abs 13', 's1e14 = abs 14', 's1e15 = abs 15', 's1e16 = abs 16', 's1e17 = abs 17', 's1e18 = abs 18', 's1e19 = abs 19', 's1e20 = abs 20', 's1e21 = abs 21', 's1e22 = abs 22', 's1e23 = abs 23', 's1e24 = abs 24', 's1e25 = abs 25', 's1e26 = abs 26', 's1e27 = abs 27', 's1e28 = abs 28', 's1e29 = abs 29', 's1e30 = abs 30', 's1e31 = abs 31', 's1e32 = abs 32', 's1e33 = abs 33', 's1e34 = abs 34', 's1e35 = abs 35', 's1e36 = abs 36', 's1e37 = abs 37', 's1e38 = abs 38', 's1e39 = abs 39', 's1e40 = abs 40', 's1e41 = abs 41', 's1e42 = abs 42', 's1e43 = abs 43', 's1e44 = abs 44']'
2016-06-10 11:37:38,110 (-b5ef470) :  DEBUG (__init__:651) - Update() - TVDB - tvdb_table: []
2016-06-10 11:37:38,110 (-b5ef470) :  DEBUG (__init__:651) - Update() - TVDB - Episodes without Summary: []

TO:

2016-06-10 11:39:32,198 (-b5ef470) :  DEBUG (networking:161) - Fetching 'http://thetvdb.com/api/A27AD9BE0DA63333/series/72745/all/en.xml' from the HTTP cache
2016-06-10 11:39:32,359 (-b5ef470) :  DEBUG (__init__:651) - Update() - TVDB - tvdb_table: ['s0e2', 's0e3', 's0e4', 's0e5', 's1e1', 's1e10', 's1e11', 's1e12', 's1e13', 's1e14', 's1e15', 's1e16', 's1e17', 's1e18', 's1e19', 's1e2', 's1e20', 's1e21', 's1e22', 's1e23', 's1e24', 's1e25', 's1e26', 's1e27', 's1e28', 's1e29', 's1e3', 's1e30', 's1e31', 's1e32', 's1e33', 's1e34', 's1e35', 's1e36', 's1e37', 's1e38', 's1e39', 's1e4', 's1e40', 's1e41', 's1e42', 's1e43', 's1e44', 's1e45', 's1e46', 's1e47', 's1e48', 's1e49', 's1e5', 's1e50', 's1e51', 's1e6', 's1e7', 's1e8', 's1e9']
2016-06-10 11:39:32,359 (-b5ef470) :  DEBUG (__init__:651) - Update() - TVDB - Episodes without Summary: []

image

from hama.bundle.

EndOfLine369 avatar EndOfLine369 commented on September 26, 2024

@sven-7, Code updated. Go ahead and pull from the master and this should now work for you.

from hama.bundle.

sven-7 avatar sven-7 commented on September 26, 2024

Yep! Works for me as well. Thanks! Closing #51.

from hama.bundle.

ZeroQI avatar ZeroQI commented on September 26, 2024

@EndOfLine369: Well done.

from hama.bundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.