Ability to just change the brightness of the lights about yetanotherhueapi HOT 5 CLOSED

I just checked out the project and made a setter for the brightness in the state class. Any real reason why the variables are final? Can't we just make them mutable and create a setter?

from yetanotherhueapi.

Hey, thanks for opening this issue! 😃 The choice between immutable and mutable objects is mostly a personal preference, and my preference tends towards using immutable objects when possible. There are trade-offs in both cases. But let me see what I can come up with concerning the brightness setting...

from yetanotherhueapi.

Thank you very much!
Will check it out later :)
Great project 👍

from yetanotherhueapi.

Great, thanks @Dustinhoefer! :) I added a setBrightness(int) method into the Light interface. It mimics the existing turnOn() and turnOff() methods. I realized that all Hue lights allow the brightness to be changed, so that was a natural place. Not all of them support for example color, so color related operations would be better kept in the State class. By modifying the Light interface I also feel like I'm respecting the philosophy that I wrote down in the README file: that essential functions should be done "in an intuitive and usable way for the programmer". ☺️

from yetanotherhueapi.

And now a similar feature (setBrightness(int)) has been added for Room objects too. 😃 It will be available in the next release.

from yetanotherhueapi.