Git Product home page Git Product logo

Comments (3)

ZeroOne3010 avatar ZeroOne3010 commented on July 24, 2024

Hi @TobseF, thank you for the compliments! :) That conversion you did was quite a feat! :o I'm not much of an Android or Kotlin programmer myself, so no, I have not had any plans to support either of them... I'm too fond of the Java 8 streams and Optionals to go back to Java 6 style of code. ;) Is there anything else I could do for you regarding the library?

from yetanotherhueapi.

TobseF avatar TobseF commented on July 24, 2024

The library worked like a charm. The only confusing thing was, that I have to choose a style of setting a light. So if I set a light by color, I'm not able to also set the brightness. E.g. it's not possible to call:
State.builder().color(Color.RED).brightness(254).
That's ok, and it make sense, if you know the HUE API, but using it for the first time was tricky.

As a Kotlin fanboy I can only advice you to give it a try. I bet you will never switch back 😉
With Optionals and Streams... it's the opposite... Kotlin solves it much better and removing them wasn't a step back.

E.g. your loved Stream API:

# Java
return Collections.unmodifiableCollection(this.sensors.values().stream()
        .filter(s -> type.equals(s.getType()))
        .map(sensorClass::cast)
        .collect(toList()));

VS

# Kotlin
return this.sensors.values.filter { type == it.type }.map (sensorClass::cast)

It's also complete typesafe. You will also receive e a unmodifiableCollection. And the "==" check also calls the equals method. And you can skip the collect(). What do you think is more expressive?

And in Kotlin Optionals are completely obsolete, because you have to specify on every type, if it's nullable or not. You can never set a String to null. If you need it, you have to declare it as String?. Then you can set it to null, but also have to check it, before you can call it. So goodby to NPEs.

KOTLIN FANBLOCK END 😁

from yetanotherhueapi.

ZeroOne3010 avatar ZeroOne3010 commented on July 24, 2024

Yeah, well, how would setting both color and brightness even work? What should happen if you set a very dark color, such as #220000, but set it to 100% brightness? So you should just choose a brighter color. :)

The StateBuilder has been designed to protect the user from setting options that are contradictory, such as setting both the color (RGB value) and the hue (a value from 0 to 65280). It does still need some work, as I've previously noted here: #9 (comment)

I suppose I do need to try Kotlin some day, maybe the next time I come up with a new project. ;)

from yetanotherhueapi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.