Comments (4)
Basically, I don't like using ThreadLocal, but it was not easy to make API compatible with jzmq without performance penalty.
The first implementation was to create Selector at the poller constructor. This was safer but some usage and example pattern was
while
create poller # creates Selector every time and has severe performance penalty
register handles
poll
At that time, there was a document to guide to create a poller outside of a loop,
create poller
register handles
while
poll
From the 0.2.0, ThreadLocal has been used as both patterns could have same performance based on assumptions.
- Poller should be created and used on the same thread
- There would not be a case which one thread needs to wait on multiple poller.
We should have enhanced the document.
from jeromq.
But this still force me to change my code...
Have you considered to move the Poller.open() from the constructor to the Poller.poll() where the selector is eventually been used in the Poller. In this way, the Poller object shoud not need to hold the selector instance and when call Poller.poll, just get it from the ThreadLocal variable and pass it to zmq.ZMQ.zmq_poll
This seems can fix my issue and have no influence on performance as 0.2.0.
from jeromq.
I would still recommend not sharing the Poller object between threads for a future change.
If you think the change is meaningful to the community, please send a pull request on it.
from jeromq.
It seems 0.3.0-SNAPSHOT have deprecated org.jeromq.ZMQ and org.zeromq.ZMQ.Poller does not holder the threadlocal variable. I will wait 0.3.0 and move to the new api
from jeromq.
Related Issues (20)
- Socket#connect hangs for ever on wrong host/port
- ZCertStore's loadFiles recursion logic is incorrect only recursing into first subdir. HOT 3
- Will there be another release? HOT 3
- Problem: Changelog is out of date
- Problem: No clear examples for Curve usage
- Problem: No automated way to deploy a release to maven central HOT 2
- socket.CLIENT does not seem to do anything in java8 HOT 2
- ipc:// protocol with zeromq. Java does support UNIX domain socket since JDK 16 HOT 1
- periodic index-out-of-bounds error HOT 9
- issue with kvmsg get/set operation HOT 2
- NPE after uplift jeromq from 0.5.2 to 0.5.3 HOT 3
- 0.5.4 and 0.6 versions HOT 3
- MsgsendBlockAndCpuIs100% HOT 7
- ipc HOT 3
- New client cannot receive any data in PUB/SUB mode HOT 1
- How to split `ZMsg` in reply envelope and request? HOT 1
- reaper-1 thread consuming 99.9% CPU HOT 2
- DEALER recv sometimes hangs HOT 5
- Export own and subscription addresses for testing HOT 3
- [Question] Message Persistence HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jeromq.