Wrong behavior when having multiple "from" places in transaction about laravel-workflow HOT 4 CLOSED

Hmmm, not quite sure. This looks like a carry-over from an earlier version of this package. Looks like the tricky part here is defining (via assoc. array in config) whether a transition should go from multiple places to one, or whether two different places can both transition to that place.

Do you have any suggestions on addressing that? Looks like the Symfony Transition class will handle an array $from (lol at the misspelling in source). My first thought would be treating the "top" level of the 'from' array in the config as the "places" and allow arrays in it. So, your diagram example would be:

// ...
'transitions' => [
            'publish' => [
                'from' => [
                   ['approved_by_journalist', 'approved_by_spellchecker']
                ]
                'to' => 'published'
            ],
// ...

Which, looking at the code, that may already support that, though it's not documented anywhere?

from laravel-workflow.

Symfony really supports arrays in $from, and, I believe, been doing so since early workflow component versions.

I have already applied the code I mentioned in first snippet. Instead of foreach:

            $transitionObj = new Transition($transitionName, $transition['from'], $transition['to']);
            $builder->addTransition($transitionObj);

            if (isset($transition['metadata'])) {
                $metadata['transitions']->attach($transitionObj, $transition['metadata']);
            }

And the diagram looks this way:

            'publish' => [
                'from' => ['approved by journalist', 'approved by spellchecker'],
                'to' => 'published'
            ],

Don't see any reason to add another level to 'from' and treat it any different from 'to'. Original YAML config is a plain array:

                publish:
                    guard: "is_fully_authenticated()"
                    from:
                        - approved by journalist
                        - approved by spellchecker
                    to: published

from laravel-workflow.

Yes, that's right. The Transition class has supported arrays since at least 3.0, but I'm not sure the YAML has. I'll have to take a closer look into how Symfony handles it (that's the biggest divergence between this package and Symfony). The issue is how to differentiate between (a) either Place1 OR Place2 can transition to Place3 and (b) BOTH Place1 AND Place2 transition to Place3.

from laravel-workflow.

I'm going to close this for now, in favor of adding this into the documentation. There may be some possible routes to explore in the future with changing this behavior based on the workflow type (state machine or workflow), though I'm not quite sure how we could make the right assumptions to keep the config as is.

Please let me know if I'm misunderstanding anything here and we can reopen this.

from laravel-workflow.