Git Product home page Git Product logo

Comments (6)

zero01101 avatar zero01101 commented on August 15, 2024

while messing with chrome last night i actually noticed it recommending the willReadFrequently attribute on the contexts? i haven't tried it yet, i actually did a simple find and replace earlier to add it in to all contexts but then quickly realized that was a terrible idea while working on issue 90 and undid it lmao

https://html.spec.whatwg.org/multipage/canvas.html#concept-canvas-will-read-frequently
https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/getContext#parameters

basically just posting this so i don't lose the link again, not sure it'll be useful at all but hey, Thing That Improves Efficiency

from openoutpaint.

seijihariki avatar seijihariki commented on August 15, 2024

We actually do have some contexts using willreadfrequently, mainly some of the temporary color brush canvases, as they are used quite a lot for the cropCanvas function.

But it is indeed a very bad idea to use this for all contexts, as it basically disables hardware acceleration.

from openoutpaint.

zero01101 avatar zero01101 commented on August 15, 2024

welp testing the 10k x 10k output uhhh yep i can definitely confirm sketching on an absurdly large canvas in firefox is unpleasant lol - seems to be exacerbated by larger brush sizes?

from openoutpaint.

jwvanderbeck avatar jwvanderbeck commented on August 15, 2024

I'm not 100% sure this is related but I'm finding even smaller canvases, with firefox it just gets slower and slower and slower the longer you are working. I've noticed iteration time on generations rise higher and higher to the point that a generation that would take seconds a few hours ago now will take hours to complete.
Then I found if I changed the webui tab (I'm using this in a1111) to a different tab other than openOutpaint, bam the generation kicks up to normal speed again until you go back to the openOutpaint tab and then it will slow down again.

from openoutpaint.

zero01101 avatar zero01101 commented on August 15, 2024

i sheepishly admit i suspect most people are using openOutpaint for longer periods than i generally do; i blame ADHD? i can't say i've noticed that specifically myself but i also generally ricochet between tabs pretty often; i wonder however if you're running into something like this issue? also mentioned in the wiki but yeah, not really sure what to do with that one as i'll experience it just in webUI directly sometimes...

from openoutpaint.

jwvanderbeck avatar jwvanderbeck commented on August 15, 2024

The bit in the wiki seems pretty descriptive. That said, I will point out that so far I have only experienced this in openOutpaint, not A1111 itself. And then only in Firefox. In Brave browser (chromium) I haven't seen this issue (though in Brave, the "send to outpaint" doesn't work so I still tend to use Firefox)

It really feels to me like something about openOutpaint is, specifically in Firefox, causing performance issues the longer you use it which causes the GPU to be unavailable fully for generation.

But I'm no expert in this, only relating my observations.

from openoutpaint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.