Git Product home page Git Product logo

Comments (9)

seijihariki avatar seijihariki commented on August 15, 2024 1

Partially done; overmask px now 20px by default.

from openoutpaint.

seijihariki avatar seijihariki commented on August 15, 2024

We can try looking for a model with "inpainting" in its name, but from what I know, there is no way to differentiate inpainting models from normal models.

On the 'overmask config', we can do that.

@zero01101 what do you think about this change?

from openoutpaint.

zero01101 avatar zero01101 commented on August 15, 2024

yeah, i was honestly trying to think of a way to make it a bit more obvious that non-inpainting models just... won't work lol... and like i don't believe any of the API endpoints return any information about how many unet channels the currently loaded model has either...

i'm of course all for a higher default value for overmask; i'm weirdly attached to that silly little function <3

from openoutpaint.

patrickas avatar patrickas commented on August 15, 2024

For whatever it is worth it, looking at the name of the file is how auto1111 webui knows it is an inpainting model and should be treated as such ....
The function that detects this is here
https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/master/modules/sd_hijack_inpainting.py#L322

from openoutpaint.

seijihariki avatar seijihariki commented on August 15, 2024

Well, if that is good enough for webui we can assume it is for us now! :)

from openoutpaint.

seijihariki avatar seijihariki commented on August 15, 2024

Will add a dialog asking if the user wants to change to an inpainting model on first run.

from openoutpaint.

zero01101 avatar zero01101 commented on August 15, 2024

For whatever it is worth it, looking at the name of the file is how auto1111 webui knows it is an inpainting model and should be treated as such ....

lmao are you serious
see i was digging around extras.py in the model merging logic where it's comparing checkpoint dimensions and assumed surely that's how other models would be verified

https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/4af3ca5393151d61363c30eef4965e694eeac15e/modules/extras.py#L297-L304

from openoutpaint.

seijihariki avatar seijihariki commented on August 15, 2024

@patrickas Could you give the compact-checkboxes branch a look? It now asks for inpainting model changes on first run.

from openoutpaint.

patrickas avatar patrickas commented on August 15, 2024

Perfect, this is exactly what I had in mind!
I think first time users will get much better results now.

And thanks for all the great work!

from openoutpaint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.