Two Weapon Fighting about raw HOT 2 CLOSED

I can kinda hack the modifier being on off-hand attack rolls, but it will use the same ability modifier of the main hand weapon (which is almost always fine - it's very rare for someone to use a finesse and non-finesse weapon at the same time). I'll try to include the negative modifier damage and see how it goes

Thanks for the suggestion for topic 3. If you want to open a pull request for that, feel free to do so. If you don't want, I'll test it out soon(ish)

from raw.

The fix assumes the player is using either two finesse or two non-finesse weapons
Attack rolls is based of the Main Weapon, so it rolls with the ability modifier. It might also use some bonuses from magic weapons, unfortunately
Damage rolls subtracts the Dexterity Modifier if it's a finesse weapon or Strenght Modifier if it's not. The WieldingFinesseWeapon check isn't super precise either, it returns true if the character is holding a finesse weapon in either hand

data "SpellRoll" "Attack(AttackType.MeleeWeaponAttack)"
data "SpellSuccess" "IF(WieldingFinesseWeapon(context.Source)):DealDamage(max(1,OffhandMeleeWeapon)-max(0,DexterityModifier), OffhandMeleeWeaponDamageType);IF(not WieldingFinesseWeapon(context.Source)):DealDamage(max(1,OffhandMeleeWeapon)-max(0,StrengthModifier), OffhandMeleeWeaponDamageType);ExecuteWeaponFunctors(OffHand)"

The end result, given the character is using two weapons of the same type, is exactly what we expect. The appropriate modifier is added to the attack roll, and the modifier is canceled on the damage roll (unless it's negative)

from raw.