[Make] Overriding file path and template file about foundry HOT 8 CLOSED

Yeah, good call, I think I'd prefer this and not add the options to the command. Maybe:

zenstruck_foundry:
    maker:
        factory:
            namespace:  DataFixtures\\Factory
            template: path/to/my/
        story:
            namespace:  DataFixtures\\Story
            template: path/to/my/

from foundry.

Hello, something like this?

make:factory --namespace=DataFixtures\\Factory --template=path/to/my/Factory.tpl.php
make:story --namespace=DataFixtures\\Story --template=path/to/my/Story.tpl.php

from foundry.

Something like this could work, it will be redundant to specify each time the folder instead of a global override, maybe this in addition with a configurable namespace and template like :

zenstruck_foundry:
    namespace:  DataFixtures\\Factory
    template: path/to/my/

Could be easier to use because in our case we will never (except for test but it's another case) be in another namespace/folder.

from foundry.

This one seems to cover maximum use case, easy to use, so it's really fine!

from foundry.

To take in consideration, the official MakerBundle makers explicitly do not support overriding the template file: symfony/maker-bundle#33 (comment) (it's of course OK to divert from that decision here, but at least it's good to know the downsides of this change)

from foundry.

I think I'm going to follow the official stance of the MakerBundle on this one. I have had a conversation with @weaverryan about possibly moving the makers from this library into the MakerBundle - adding this would complicate that process.

from foundry.

Btw, there is a difference between make:factory and make:fixture (of MakerBundle). In make:fixture, the class name is a required argument (and this defaults to a specific namespace, unless an FQCN was provided). The make:factory doesn't do this (as it has the great auto-discovery feature for entities).

I think it does make sense to add a --namespace=DataFixtures\Factory option to the makers to override the default FQCN (and the makers automatically adjust the file location based on the FQCN and composer autoloading config).

from foundry.

I think it does make sense to add a --namespace=DataFixtures\Factory

How do you think this should behave if the --test flag is used as well?

from foundry.