Foundry should not remove symfony-s errorHandlers about foundry HOT 6 CLOSED

after a lot a of digging, I've just figured out that the main reason of why we've introduced this whole "error handlers resetting" stuff is because when the kernel is booted in a "before class" hook, the deprecation won't bubble up in PHPUnit (because Symfony registers its error handler before PHPUnit, and then PHPUnit won't register its own error handler if one already exists. see both here and here

So we had to find a way to prevent this when using ResetDatabase. But it is not needed to reset the error handler in a setup() hook (aka #[Before]), and it is where the problem Test code or tested code removed error handlers other than its own comes from. At then end, the solution would be to not only reset error handlers in ResetDatabase::_resetDatabase() which is the only place where Foundry boots the kernel in a "before class" hook.

from foundry.

I've released v1.38.2 & v2.0.3. I'm closing the issue, feel free to reopen it if you still have problems with this

from foundry.

Just tested with 1.38.2 and it fixed my issue. Thanks

from foundry.

Hi @mmarton

this is a complex topic, the main problem with the workardound set_exception_handler([new ErrorHandler(), 'handleException']); added in boostrap.php is that Symfony exception handler does not let deprecation warnings bubble up to PHPUnit's one...

Still, I do understand that the chosen solution is unfortunate as well. more over the problem is between Symfony and PHPUnit, and Foundry has nothing to deal with it.. But for the migration between foundry v1 and v2, the ability to display deprecation is kinda super helpful.

The problem occurs because methods marked as #[BeforeClass] in the traits occur before TestCase::setUpBeforeClass() and then Symfony's exception handler is not removed afterwards if the kernel is booted there.

I think our hands are tied here 😞

(I've been thinking about introducing a PHPUnit Extension for Foundry for a long time, maybe that would be a way to mitigate this problem. But we would still need to mess around with Symfony's exception handler, which is not Foundry's responsibility, I admit)

@kbond any thoughts?

from foundry.

@mmarton, to confirm, are you using phpunit 10+?

from foundry.

@mmarton, to confirm, are you using phpunit 10+?

Yes, the latest 11.2 version

from foundry.