"StrictSlash" Mode about goji HOT 4 CLOSED

I just came across this and I dont think its too much magic. If I I have Get("/env/") and called it with both /env and /env/ I'd expect both to be hit

We do the same in Nancy 😄

from goji.

I actually intentionally left this functionality out, both because I saw other frameworks doing it (Sinatra, I think), and because it introduces non-obvious "magic" into the routing process.

I think the right way to introduce this functionality is using middleware (LMK if you disagree), and writing such a middleware is on my TODO list (although I'd happily accept a PR if you have one handy).

from goji.

I don't disagree on having it as a middleware, so no problems there.

As long as it can be easily applied to all routes of a router and isn't
significantly less performant than a non-middleware implementation then I'm
easily pleased!

PS: Goji is looking fantastic and the straightforward middleware
implementation is great. I may look at providing some CSRF and HTTP Basic
Auth middleware as PRs if there's interest on your part.

On Saturday, April 26, 2014, Carl Jackson [email protected] wrote:

I actually intentionally left this functionality out, both because I saw
other frameworks doing it (Sinatra, I think), and because it introduces
non-obvious "magic" into the routing process.

I think the right way to introduce this functionality is using middleware
(LMK if you disagree), and writing such a middleware is on my TODO list
(although I'd happily accept a PR if you have one handy).

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/9#issuecomment-41464281
.

from goji.

It's been a while since this issue was filed, and I don't realistically see myself having enough time to work on it. Since there isn't obviously a huge desire for this functionality I'm going to go ahead and close this issue, but if this changes in the future you should feel free to re-open it and I'll see if I can devote some time to writing something nice here.

For what it's worth, I plan on exposing a little more of the router's innards in the future, which will make writing a StrictSlash middleware a teensy bit easier.

from goji.