DS3231 vs DS3231M about ds3231m HOT 7 CLOSED

You are correct, I don't know how that slipped by me!

from ds3231m.

I have made a some changes to the code which make this pull request a bit of a chore to integrate, so I am going to add your code to my branch and integrate that..

from ds3231m.

I've added the changes, having changed the code just a little bit to stay backwards-compatible. I'll draft a new 1.0.7 release that will include this additional functionality as well. Thanks!

from ds3231m.

thanks for you!
I believe that writeByte(DS3231M_CONTROL, readByte(DS3231M_CONTROL) & ~B00111000); line 528
should be writeByte(DS3231M_CONTROL, readByte(DS3231M_CONTROL) & ~B00011100);

in writeByte(DS3231M_CONTROL, (readByte(DS3231M_CONTROL) & ~B00111000) | (rate | B00000011) << 3); line 540
should be writeByte(DS3231M_CONTROL, (readByte(DS3231M_CONTROL) & ~B00011100) | (rate & B00000011) << 3);
in the next few days I will prove this.

from ds3231m.

I forgot to highlight the change between the "or" and "and" in the previous comment, line 540, otherwise the output would always be 8khz
sorry

from ds3231m.

I have tested today on arduino nano and it works as expected pinSquareWave () and pinSquareWave (const uint8_t rate) .
thanks!

from ds3231m.

That's great news - I'm glad we could make the library work better.

from ds3231m.