Git Product home page Git Product logo

Comments (12)

MangelMaxime avatar MangelMaxime commented on August 25, 2024 1

A less strict pinning strategy could be:

{
    "sdk": {
        "version": "6.0.0",
        "rollForward": "latestMinor"
    }
}

from femto.

mrakgr avatar mrakgr commented on August 25, 2024 1

Nice. I'll give it a try tomorrow.

Edit: I gave it a try and it works. It is not a thorough test, but it is good that I can use .NET 7 issue now. Thanks.

from femto.

mrakgr avatar mrakgr commented on August 25, 2024

The issue I had with Femto silently not updating the packages seems to be exactly this. I can confirm that trying to resolve a project with the prerelease 4.0.0 Fable and the global.json deleted causes Femto to not resolve the NPM packages. As soon as I downgraded, it started working again.

from femto.

Zaid-Ajaj avatar Zaid-Ajaj commented on August 25, 2024

Fixed as of Femto v0.17.0 🚀 which now supports projects targeting net7.0

from femto.

mrakgr avatar mrakgr commented on August 25, 2024

I found an issue. Check out: https://github.com/mrakgr/SAFE-TodoList/tree/671b8bc4cd553aef7e7b329a5c0b4aa2b5b2cbd8

PS E:\Webdev\Fable\Safe Stack Examples\SAFE-TodoList> dotnet femto src/client --resolve                
[16:30:36 INF] Analyzing project E:/Webdev/Fable/Safe Stack Examples/SAFE-TodoList/src/client/Client.fsproj
[16:30:36 INF] Running dotnet restore against the project
[16:30:41 INF] Using npm for package management
[16:30:41 INF] Found package.json in E:\Webdev\Fable\Safe Stack Examples\SAFE-TodoList
[16:30:41 INF] Npm packages need to be restored first for project analysis
[16:30:41 INF] Restoring npm packages using 'npm install' inside E:\Webdev\Fable\Safe Stack Examples\SAFE-TodoList
[16:30:48 INF] ✔ Required packages are already resolved
PS E:\Webdev\Fable\Safe Stack Examples\SAFE-TodoList> 

When I run this, it looks like it finishes correctly, but it doesn't install react and react-dom properly. If I add the globals.json file it starts working again.

from femto.

mrakgr avatar mrakgr commented on August 25, 2024

Also, Fable.Elmish.Debugger requires the remotedev package, but it doesn't get resolved even with globals.json. I wonder if it is missing in the package metadata?

from femto.

MangelMaxime avatar MangelMaxime commented on August 25, 2024

@mrakgr For Fable.Elmish.Debugger, this is because the package doesn't have the Femto metadata.

This is because the project was created before Femto. In general, the remotedev package is injected by the browser extension or webpack I don't remember.

from femto.

Zaid-Ajaj avatar Zaid-Ajaj commented on August 25, 2024

@mrakgr does it work when you manually npm install?

from femto.

mrakgr avatar mrakgr commented on August 25, 2024

@Zaid-Ajaj That wouldn't add the react and react-dom dependencies to package.json. I need Femto for that. But once they are there it would work.

from femto.

Zaid-Ajaj avatar Zaid-Ajaj commented on August 25, 2024

@mrakgr first npm install then femto --resolve should get you the right packages even after npm install is done but I agree, femto should do npm install on its own when needed

from femto.

mrakgr avatar mrakgr commented on August 25, 2024

@Zaid-Ajaj I didn't realize that. With .NET 6 it works right away using just --resolve.

from femto.

Zaid-Ajaj avatar Zaid-Ajaj commented on August 25, 2024

@mrakgr yeah even if you mess up your npm package versions manually, femto --resolve will get the right versions back. I will see why femto isn't automatically executing npm install

from femto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.