Comments (7)
Cool, I'll likely wait till the next time something needs to be merged in and tack that on so that specific tags don't need to be created each time.
Thank you both for the additions!
from go-splunk-http.
That second error makes it sounds like your module can't have a major version higher than that of golang by only mentioning v0 and v1. It doesn't help that I've been out of golang since before modules were introduced...
from go-splunk-http.
Unfortunately "v2 and above" has to be treated differently with Go modules, and it's really annoying:
In semantic versioning, changing the major version number indicates a lack of backwards compatibility with earlier versions. To preserve import compatibility, the go command requires that modules with major version v2 or later use a module path with that major version as the final element
-- https://golang.org/cmd/go/#hdr-Module_compatibility_and_semantic_versioning
from go-splunk-http.
Deleting the github release v2.0.0 for this wouldn't create an issue would it? @antoineco
from go-splunk-http.
@ZachtimusPrime no, go ahead 👍 It's not compatible with modules anyway.
There is an important detail to consider though. The go.mod
file is in the sub-module splunk/
, so you need to create a tag called splunk/v2.0.1
for go get
to work as expected, not v2.0.1
.
$ go get github.com/ZachtimusPrime/Go-Splunk-HTTP/splunk/[email protected]
go get github.com/ZachtimusPrime/Go-Splunk-HTTP/splunk/[email protected]: github.com/ZachtimusPrime/Go-Splunk-HTTP/splunk/[email protected]: invalid version: unknown revision splunk/v2.0.1
You can do that without affecting the release you just created:
git tag splunk/v2.0.1
git push --tags
git tag --delete v2.0.1
git push -d origin v2.0.1
Example of popular projects that also use sub-modules:
- https://github.com/cloudevents/sdk-go/releases/tag/protocol%2Fnats%2Fv2.3.0
- https://github.com/Azure/azure-sdk-for-go/releases/tag/sdk%2Fazcore%2Fv0.12.1
from go-splunk-http.
@antoineco Would moving the go.mod
file into root work as well? To prevent having to remember to push a new splunk/vX.X.X
tag with each release.
In the meantime, the tags have been updated.
from go-splunk-http.
@ZachtimusPrime sweet, it looks good now on my side, thanks a lot!
You could move ./splunk/v2
to ./v2
and it would do what you expect, yes. If you do that, don't forget to update go.mod
to reflect the change of path as well.
from go-splunk-http.
Related Issues (7)
- Logs are only accurate to the second
- Update filepaths and go.mod contents to support default release tags HOT 1
- NewEventWithTime ignores provided timestamp
- splunk.NewClient shouldn't be using InsecureSkipVerify by default
- Include a logrus hook that will automatically forward logs to splunk
- http connection not closing properly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-splunk-http.