Comments (5)
z0al
commented on June 1, 2024
1
Thanks for investigating this @ulope. I will read more about this in the morning and update the docs accordingly 👍
Looks like this is a known issue with github actions and forked PRs.
That's correct. I was not aware of pull_request_target. Thanks for bringing that to my attention.
from dependent-issues.
z0al
commented on June 1, 2024
1
You are right. I updated the docs accordingly.
from dependent-issues.
ulope
commented on June 1, 2024
Looks like this is a known issue with github actions and forked PRs.
Apparently using pull_request_target instead of pull_request solves the problem: https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/#improvements-for-public-repository-forks
Will try and report back.
from dependent-issues.
ulope
commented on June 1, 2024
Ok this fixed the issue.
So maybe changing the documentation to use the pull_request_target trigger would make sense.
from dependent-issues.
github-actions
commented on June 1, 2024
🎉 This issue has been resolved in version 1.0.5 🎉
The release is available on GitHub release
Your semantic-release bot 📦🚀
from dependent-issues.
Related Issues (20)
- Question: Does it remove the changes from dependant PRs when reviewing in the Files section ? HOT 1
- dependabot issues are ignored, but don’t need to be HOT 5
- Unconditional blocker HOT 1
- Could u help? :)
- Comment is too spammy HOT 7
- Trigger workflow from remote repo HOT 3
- Status remains pending even after closing the dependent issue HOT 5
- Backreferences? HOT 2
- duplicated comments HOT 5
- question about dependencies
- HttpError: API rate limit exceeded for installation ID 9256508 HOT 2
- Warning: Unexpected input(s) 'ignore_dependabot', valid inputs are ['label', 'check_issues', 'keywords', 'comment'] HOT 2
- Allow for keywords on comments as well HOT 1
- Update workflow documentation HOT 1
- Workflow minimum permissions HOT 1
- HttpError: Not Found HOT 8
- Deprecated node warning
- Does not work with merge queues
- Error: env.GITHUB_TOKEN must not be empty HOT 1
- Request: Allow for separate comment when all dependencies met
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dependent-issues.