Git Product home page Git Product logo

Comments (6)

gunzip avatar gunzip commented on July 26, 2024 1

@yvele you were right, it depends on node version (it works against 6.x)

from azure-function-express.

luchsamapparat avatar luchsamapparat commented on July 26, 2024

After I fixed this issue locally, I stumbled upon another issue. The library I use, contains the following to calls:

		res.writeHead(302, null, {
			'Access-Control-Allow-Origin': '*',
			'Location': path
		});

		res.end();

But when looking at the implementation of end, it seems that the status code is overwritten:

function end(context, data, encoding) {
  // 1. Write head
  this.writeHead(this.statusCode); // Make jshttp/on-headers able to trigger

  // 2. Return raw body to Azure Function runtime
  context.res.body = convertToBody(data, encoding);
  context.res.isRaw = true;
  context.done();
}

writeHead does not set this.statusCode which leads to end setting the statusCode to 200. Is this the intended behavior? In my case this means, that the Location header is ignored by the browser as the status code is not within the 3** range.

from azure-function-express.

yvele avatar yvele commented on July 26, 2024

@luchsamapparat thank you for your investigation on this.

May I ask you what exactly is the library you are using?

from azure-function-express.

luchsamapparat avatar luchsamapparat commented on July 26, 2024

I'm using oauth-shim to build an OAuth proxy according to the documentation from hello.js.

The implementation is pretty simple as you just have to configure Express.js to use oauth-shim:

const express = require("express");
const createHandler = require("azure-function-express").createHandler;
const oauthshim = require('oauth-shim');
const param = require('oauth-shim/src/utils/param');

const app = express();

app.all('/api/oauth-btg', oauthshim);

// monkey patch for writeHead issue in azure-function-express
oauthshim.redirect = function (req, res, next) {
	if (req.oauthshim && req.oauthshim.redirect) {
		let hash = req.oauthshim.data;
		let path = req.oauthshim.redirect;

		path += (hash ? '#' + param(hash) : '');

		// bugfix: always pass statusMessage as second param
		res.writeHead(302, null, {
			'Access-Control-Allow-Origin': '*',
			'Location': path
		});

		res.statusCode = 302;
		res.end();
	}
	else if (next) {
		next();
	}
};

oauthshim.init([{
	client_id: 'XXX',
	client_secret: 'XXX',
	grant_url: 'https://login.microsoftonline.com/common/oauth2/v2.0/token',
	domain: 'XXX'
}]);

module.exports = createHandler(app);

from azure-function-express.

gunzip avatar gunzip commented on July 26, 2024

maybe it's me but i cannot get this call to this._renderHeaders() here:

https://github.com/yvele/azure-function-express/blob/master/src/OutgoingMessage.js#L67

where does _renderHeaders() come from ? (not in the azure-functions response object)
my app crashes with a NPE just there.

from azure-function-express.

yvele avatar yvele commented on July 26, 2024

@gunzip what version of Node.js are you using? Because it's only compatible with 6.x.x

from azure-function-express.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.