Git Product home page Git Product logo

Comments (2)

ezequiel avatar ezequiel commented on July 30, 2024

Hi @rgrove,

This would be a really nice addition, especially seeing as how YUI already allows us to successfully call Node#setHTML() on a fragment. I thought about your technique for a bit, and realized there is one flaw in it.

If you append a document fragment anywhere, all the elements contained in the fragment will be removed. This is certainly undesirable side effect if all we're trying to do is get the innerHTML. We may have wanted to do something with those elements later on.

I came up with another solution, which avoids the side effect by deep cloning the fragment. It may be a bit expensive, but I don't think it will cause any noticeable slow downs that are troubling, since fetching the innerHTML of an element is only a small part of any application.

Here's a jsfiddle describing the aforementioned: http://jsfiddle.net/EM7hY/1/

I will submit a pull request with my proposed changes and reference this issue.

from yui3.

rgrove avatar rgrove commented on July 30, 2024

Resolved by #943, yay!

from yui3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.