Git Product home page Git Product logo

Comments (2)

dainnilsson avatar dainnilsson commented on June 16, 2024

I'm not a fan of options 2 or 3, really. Mainly I want to avoid having to pull in hidapi as a dependency in the server library.

Regarding the utils modules these are probably simple enough that duplication isn't a big deal. The soft U2F device is a bit more complex, and it would be good to avoid having it duplicated. Since it's only used in the server library for testing it might be fine to add the host library as a test dependency.

As for option 4 I don't think the current duplication warrants the overhead of adding a new package. An option would be to use the yubicommon package for this, but I'd like to avoid having it contain too package specific code. The utils stuff might be fine for it.

from python-u2flib-host.

moreati avatar moreati commented on June 16, 2024

I agree utils.py duplicates are small enough to stay where they are.

Making python-u2flib-host a test_requires of python-u2flib-server feels like a good idea. I'd prefer not to put anything in yubicommon that's specific to U2F.

from python-u2flib-host.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.