Comments (2)
I'm not a fan of options 2 or 3, really. Mainly I want to avoid having to pull in hidapi as a dependency in the server library.
Regarding the utils modules these are probably simple enough that duplication isn't a big deal. The soft U2F device is a bit more complex, and it would be good to avoid having it duplicated. Since it's only used in the server library for testing it might be fine to add the host library as a test dependency.
As for option 4 I don't think the current duplication warrants the overhead of adding a new package. An option would be to use the yubicommon package for this, but I'd like to avoid having it contain too package specific code. The utils stuff might be fine for it.
from python-u2flib-host.
I agree utils.py
duplicates are small enough to stay where they are.
Making python-u2flib-host
a test_requires of python-u2flib-server
feels like a good idea. I'd prefer not to put anything in yubicommon that's specific to U2F.
from python-u2flib-host.
Related Issues (20)
- Dependencies for Python 3 and PyPy support HOT 6
- u2flib_host.exc.APDUError: 0x6985 HOT 4
- TypeError: valid_facets() takes exactly 3 arguments (2 given) HOT 1
- hid_transport list_devices() method only returns the class name instead of an actual device object HOT 1
- Not actually compatible with python3 HOT 2
- communication between python-u2flib-host and python-u2flib-server HOT 5
- Yubikey Nano 4 not returned by u2f.list_devices()
- setup.py includes non existing file HOT 1
- Struct pack error HOT 1
- u2f-register :command not found??!! HOT 3
- How to add rules into rules.d? I don't know the detailed steps.Can you help me? HOT 1
- what should we do for a real Yubikey??Can anyone help me? HOT 1
- Wrong U2F Command parameter when U2F_REGISTER HOT 1
- JaCarta U2F support in known devices
- Support Thetis U2F key HOT 1
- u2flib_host.exc.APDUError: 0x6A80
- Add Trezor devices
- Document what versions of Python are supported HOT 2
- Scripts still contain GPL license header HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from python-u2flib-host.