Git Product home page Git Product logo

Comments (10)

adlerluiz avatar adlerluiz commented on July 25, 2024 1

Seems to be a specific error for mac since in windows i didn't have this problem

from ytmdesktop.

mingjun97 avatar mingjun97 commented on July 25, 2024 1

From my test, ytmusic might not update track title to the page title. I'm not sure if page-title-updated event will be triigerred. I'm thinking use MutationObserver to monitor the modification of the div of title. It should works.

from ytmdesktop.

mingjun97 avatar mingjun97 commented on July 25, 2024 1

Sorry for that. I didn't notice that the updateActivity will incur such problem. Maybe temporarily disable this patch? I'm a little busy recently.

from ytmdesktop.

mingjun97 avatar mingjun97 commented on July 25, 2024

image
Far away from current track. Seems like the track switch in YTMusic won't raise media-started-play event anymore. I'll add a complementary hook at did-navigate-in-page.

from ytmdesktop.

mingjun97 avatar mingjun97 commented on July 25, 2024

Or we need a more robust way to retrieve the track's title?

from ytmdesktop.

adlerluiz avatar adlerluiz commented on July 25, 2024

Yes, we need a more robust way, but to get track info maybe can see too page-title-updated

from ytmdesktop.

mingjun97 avatar mingjun97 commented on July 25, 2024

Tried MutationObserver, it seems not gonna to work since the YTM only update innerText which will not observered by MutationObserver. Finally, I add a complementary monitor to the did-start-navigate event handler.

from ytmdesktop.

adlerluiz avatar adlerluiz commented on July 25, 2024

Testing new feature (LastFM integration) i see the problem too

image

from ytmdesktop.

adlerluiz avatar adlerluiz commented on July 25, 2024

because updateActivity is called 2 times

image

from ytmdesktop.

rickpalmeira avatar rickpalmeira commented on July 25, 2024

Fixed on v1.6

from ytmdesktop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.