yt code_length unit inconsistent with Ramses unit_l about yt HOT 4 OPEN

Hi, and welcome to yt! Thanks for opening your first issue. We have an issue template that helps us to gather relevant information to help diagnosing and fixing the issue.

from yt.

Thanks for bringing this up -- I am sorry we didn't address it before! Perhaps @cphyc can provide some insight?

from yt.

I'm happy to help but I'm 200% busy until February 9 and won't have time until then. Most likely, these two lines are the right entry points:

The first sets the length_unit, so 1 * length_unit equals the box size. The second sets the size of the box.
I wonder if the fix is simply to replace the latter by

        self.domain_right_edge = np.full(3, self.parameters["boxlen"], dtype="float64")

Could you try and let us know if this works? If it does, we'd be happy for you to submit a PR, or I can do it in a couple of weeks.

from yt.

Hi,

Thanks for the quick reply. I tried changing the line you suggested, and this does mean the correct domain_right_edge is returned when loading the data:

yt : [INFO     ] 2024-01-24 16:11:33,248 Parameters: domain_right_edge         = [150. 150. 150.]

However, the ratio code_length/unit_l is still incorrect by a factor of boxlen and I get the same offset in my plots.

I also tried removing the factor of boxlen in line 977 to give:

setdefaultattr(self, "length_unit", self.quan(length_unit , "cm")) 

I'm completely new to both Ramses and yt so I'm not sure if it was logical to do this, but this seems to completely break any plots I make of the gas.

from yt.