Package Cython-generated *.cpp and *.c files about yt HOT 5 CLOSED

Wowza, that is a lot!

My understanding -- which may in fact be incorrect -- is that a lot of the code in these is identical between files. For instance,

grep -Fxf yt/frontends/gamer/cfields.c yt/frontends/ramses/io_utils.c|wc

returns about 1.1M of data over 32000 lines. I believe that if we had these linked into the same object file, it would not. That's ... probably too much of a lift, though.

Alternately, I think we would be in the clear if we did not package the generated source in the wheels, but retained it in the source tarballs.

from yt.

related:

• current state of documentation: https://cython.readthedocs.io/en/latest/src/userguide/source_files_and_compilation.html?highlight=wheel#distributing-cython-modules
• open issue on Cython: cython/cython#5089 (comment)

@matthewturk , what's your rationale for including these files in source dist ?

from yt.

Note that, since installing yt requires Cython and Cython builds are deterministic, I don't really see why we would include the generated source files anymore. The only advantage of doing so would be to be able to compile directly the source files without needing Cython, but (a) we're currently not supporting this and (b) if we were to support it, that would make our setup more complex. Is it worth it?

from yt.

I also don't think it's worth it. I think those C files were a useful resource some time back, before the build system configuration was standardised (pyproject.toml), but it's most likely useless now that we don't support any version of Python that's older than this spec any more.

from yt.

from yt.