Git Product home page Git Product logo

Comments (4)

yosukefk avatar yosukefk commented on August 11, 2024

Actually, i'd get rid of this option, it doesnt have to be set when container got created. I'd put this to jupyter notebook.

from finn_preproc.

mbjoseph avatar mbjoseph commented on August 11, 2024

Hey @yosukefk! Originally I had the same idea, but then realized that if the username and password are in the notebook, that would provide a security risk if the notebook exists on a public GitHub repository. So, providing them as environment variables in the call to docker run seemed less likely to cause users to expose their credentials.

But, I'm open to other ways to pass in credentials!

from finn_preproc.

yosukefk avatar yosukefk commented on August 11, 2024

I see, @mbjoseph , never thought about that. We may want to keep the way you did. We still need documentation of what is needed and why needed.

from finn_preproc.

yosukefk avatar yosukefk commented on August 11, 2024

Done

from finn_preproc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.