Comments (2)
Since Go automatically handles the garbage collection for objects that are not being referenced, there's no need for specific garbage collection implementation for rhtNode. Hence, I'm closing this issue.
Additionally, it seems that garbage collection for ElementRHT, which is already implemented, may not be necessary. I'll address the garbage collection removal for ElementRHT in a new issue.
The case where the reference count becomes 0 is when the value corresponding to the existing key is overwritten in the process of RHT.set
. Therefore, there is no need for gc logic in RHT.set.
In the case of RHT.Remove
, however, it is still a required specification in the concurrent editing scenario, so I reopen the issue.
from yorkie.
This was fixed by #864.
from yorkie.
Related Issues (20)
- Support collecting metrics for MongoDB sharded clusters HOT 4
- Define REST API Spec for Consistent Usage of Project Key HOT 5
- Cannot find node of CRDTTreePos HOT 1
- Incorrect indexes in TreeChange when running Tree.Style HOT 1
- Divergence by concurrent Tree.Edit and Tree.RemoveStyle
- Tree inconsistency between Changes-generated and Snapshot-generated HOT 1
- Duplicate changes pushes during simultaneous sync and detach calls
- Resolve Split-Brain of WatchDocument with Stateful Session Affinity
- Handling reattaching detached document in SDK HOT 1
- Synchronization fails when editing including Undo In the CodeMirror example. HOT 1
- Update Document updatedAt to only include Document.Root modifications HOT 2
- Issue with document deletion in MemDB causing malfunction
- Implement DB Query for GetDocuments API to improve performance HOT 9
- Provide detailed error codes for enhancing error handling from Client
- Improve performance for creating crdt.TreeNode HOT 5
- Resolve N+1 issue in GetDocuments API response when snapshot is included
- Remove gRPC Dependency in the Codebase
- Improve performance of Splay Tree in crdt.Text data structure to prevent skewness HOT 1
- Error occurs when executing `FindDocInfosByKeys` query with empty docKeys argument HOT 1
- Server panics due to convert unhashable struct to connnect.Error HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from yorkie.