Git Product home page Git Product logo

Comments (4)

computerphilosopher avatar computerphilosopher commented on July 28, 2024 1

If we set flags to DurationVar, we can use duration string as a flags' value.

But I didn't use it in #152 because flags' names are 'second', not 'duration'.

I think we should rename flags to --mongo-connection-timeout(remove postfix 'second')

from yorkie.

hackerwins avatar hackerwins commented on July 28, 2024

@computerphilosopher Yes of course. We have to change it.

from yorkie.

hackerwins avatar hackerwins commented on July 28, 2024

There are still TimeoutSec and TimeSec missing.

type Config struct {
Endpoints []string `json:"Endpoints"`
DialTimeoutSec time.Duration `json:"DialTimeoutSec"`
Username string `json:"Username"`
Password string `json:"Password"`
LockLeaseTimeSec int `json:"LockLeaseTimeSec"`
}

from yorkie.

dc7303 avatar dc7303 commented on July 28, 2024

I was distracted the other day and couldn't take care of it.
I will proceed!

from yorkie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.