Hey <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url=

Fix silent failures about mint HOT 3 CLOSED

yonaskolb commented on May 4, 2024

Fix silent failures

from mint.

Comments (3)

yonaskolb commented on May 4, 2024

Interesting. It's designed to print errors in red, but something must be going wrong with the error checking

Mint/Sources/MintKit/Mint.swift

Lines 332 to 335 in 0add0a4

 let output = context.run(bash: command) 

 if let error = output.error { 

 throw error 

 }

from mint.

josefdolezal commented on May 4, 2024

Oh, you are right! The error is actually thrown from the referenced place, but it is later ignored here

Mint/Sources/Mint/main.swift

Lines 12 to 15 in 1d0f8cc

 switch error { 

 case let .inAccessibleExecutable(path): main.stderror.print("Couldn't run command \(path)") 

 case let .returnedErrorCode(command, _): break 

 }

The change was introduced in 263272c. May we change this back to the previous behaviour? The command exits with status code 1 either way.

from mint.

yonaskolb commented on May 4, 2024

I think I removed that because Mint was printing its own errors instead of letting the tool show them when running. Installing should be different though. I’ll fix it

from mint.

Fix silent failures about mint HOT 3 CLOSED

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	let output = context.run(bash: command)
	if let error = output.error {
	throw error
	}

	switch error {
	case let .inAccessibleExecutable(path): main.stderror.print("Couldn't run command \(path)")
	case let .returnedErrorCode(command, _): break
	}