Comments (9)
@aLekSer Thank you very much for the report.
I will investigate it soon.
from protolint.
Looks like it dislikes:
string owner_machine_id = 3 [(validator.field) = {regex: "^[A-z0-9-]+$"}];
this is part of https://github.com/mwitkow/go-proto-validators
from protolint.
@xackery thanks for the report.
Let me check.
from protolint.
string owner_machine_id = 3 [(validator.field) = {regex: "^[A-z0-9-]+$"}];
https://github.com/yoheimuta/go-protoparser already supports the option of go-proto-validators.
protolint parses this line well under my environment.
merged #23 with a verbose flag support.
Care to try with -v flag? And if you can please provide me with a reproducible test case, it would be much appreciated.
from protolint.
I got this bug on this file:
https://github.com/googleforgames/agones/blob/master/sdk.proto
2019/06/12 12:35:04 [DEBUG] Text=[{], Token=[14], Pos=[sdk.proto:27:36] called from lexer.go:127
found "{" but expected [constant] at /Users/alexander/go/src/github.com/yoheimuta/go-protoparser/internal/lexer/constant.go:38
Seems to could not parse option (google.api.http) = {
:
service SDK {
// Call when the GameServer is ready
rpc Ready (Empty) returns (Empty) {
option (google.api.http) = {
post: "/ready"
body: "*"
};
}
...
}
from protolint.
@aLekSer I understand the issue. I will first fix yoheimuta/go-protoparser#22.
from protolint.
@aLekSer #26 fixed this issue.
Could you confirm it's OK?
from protolint.
Yes, now it is ok, and option () = {}
got parsed well.
from protolint.
Thanks for confirming!
from protolint.
Related Issues (20)
- Bug: Enum field prefix naming rule HOT 3
- Stray double semi-colon cause erratic results
- protolint npm package isn't available HOT 3
- Error thrown when installing protolint through yarn HOT 1
- Can't read Unix domain socket as a file
- FILE_NAMES_LOWER_SNAKE_CASE fails to convert kebab case to snake case HOT 2
- RPC_NAMES_UPPER_CAMEL_CASE disable is ignored HOT 1
- Some rules do not support auto-disable HOT 5
- Allow exclusion list of field names for `FIELDS_HAVE_COMMENT` HOT 1
- ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH failing even with `allow_alias = true` HOT 1
- CVEs in the latest version HOT 2
- Create folder for reporting output file
- Using config_path plugin parameter does not work
- panic in `protolint --fix`
- Json Report Enhancements HOT 3
- Configure rule severity via protolint config HOT 1
- Configuring severity does not work for MaxLineLengthRule HOT 1
- Rule for first value of enum should have numeric value zero? HOT 3
- Bug: Missing 'new' in https://github.com/yoheimuta/protolint/blob/master/bdist/js/install.mjs HOT 4
- please fix license inconsistency HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from protolint.