Git Product home page Git Product logo

Comments (9)

yoheimuta avatar yoheimuta commented on August 20, 2024 1

@aLekSer Thank you very much for the report.
I will investigate it soon.

from protolint.

xackery avatar xackery commented on August 20, 2024

Looks like it dislikes:
string owner_machine_id = 3 [(validator.field) = {regex: "^[A-z0-9-]+$"}];

this is part of https://github.com/mwitkow/go-proto-validators

from protolint.

yoheimuta avatar yoheimuta commented on August 20, 2024

@xackery thanks for the report.

Let me check.

from protolint.

yoheimuta avatar yoheimuta commented on August 20, 2024

@xackery

string owner_machine_id = 3 [(validator.field) = {regex: "^[A-z0-9-]+$"}];

https://github.com/yoheimuta/go-protoparser already supports the option of go-proto-validators.
protolint parses this line well under my environment.

merged #23 with a verbose flag support.

Care to try with -v flag? And if you can please provide me with a reproducible test case, it would be much appreciated.

from protolint.

aLekSer avatar aLekSer commented on August 20, 2024

I got this bug on this file:
https://github.com/googleforgames/agones/blob/master/sdk.proto

2019/06/12 12:35:04 [DEBUG] Text=[{], Token=[14], Pos=[sdk.proto:27:36] called from lexer.go:127
found "{" but expected [constant] at /Users/alexander/go/src/github.com/yoheimuta/go-protoparser/internal/lexer/constant.go:38                                                                  

Seems to could not parse option (google.api.http) = {:


service SDK {
    // Call when the GameServer is ready
    rpc Ready (Empty) returns (Empty) {
        option (google.api.http) = {
            post: "/ready"
            body: "*"
        };
    }
...
}

from protolint.

yoheimuta avatar yoheimuta commented on August 20, 2024

@aLekSer I understand the issue. I will first fix yoheimuta/go-protoparser#22.

from protolint.

yoheimuta avatar yoheimuta commented on August 20, 2024

@aLekSer #26 fixed this issue.
Could you confirm it's OK?

from protolint.

aLekSer avatar aLekSer commented on August 20, 2024

Yes, now it is ok, and option () = {} got parsed well.

from protolint.

yoheimuta avatar yoheimuta commented on August 20, 2024

Thanks for confirming!

from protolint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.