Git Product home page Git Product logo

Comments (2)

PaulSonOfLars avatar PaulSonOfLars commented on August 20, 2024 1

Seems like I missed the structure style section; If thats what google recommends, then I would use that.

In which case, I'm just disappointed that they ignore their own guidelines...

You mean that the ORDER rule, which equals to the Google Style Guide, should allow a few exceptions about option and import in some situations, rather than forcing end-users to turn entire off.

Yes, that was what I was saying. However, if the styleguide says file options should be after imports, then I might be wrong, and your approach might be better.

from protolint.

yoheimuta avatar yoheimuta commented on August 20, 2024

@PaulSonOfLars Thank you for taking care of the issue!

Let me know the following to understand the problem clearly.

Certain protos contain simple option assignments at the top of the file, before the imports. Linting these results in the following lint violation:

These files are violating the file structure of the Google Style Guide.
Is it right?

My opinion is that there should be a toggle available to edit the ORDER setting, which allows simple option assignments to be placed before imports.

You mean that the ORDER rule, which equals to the Google Style Guide, should allow a few exceptions about option and import in some situations, rather than forcing end-users to turn entire off.
Is my understanding correct?

from protolint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.