Comments (2)
Seems like I missed the structure style section; If thats what google recommends, then I would use that.
In which case, I'm just disappointed that they ignore their own guidelines...
You mean that the ORDER rule, which equals to the Google Style Guide, should allow a few exceptions about option and import in some situations, rather than forcing end-users to turn entire off.
Yes, that was what I was saying. However, if the styleguide says file options should be after imports, then I might be wrong, and your approach might be better.
from protolint.
@PaulSonOfLars Thank you for taking care of the issue!
Let me know the following to understand the problem clearly.
Certain protos contain simple option assignments at the top of the file, before the imports. Linting these results in the following lint violation:
These files are violating the file structure of the Google Style Guide.
Is it right?
My opinion is that there should be a toggle available to edit the ORDER setting, which allows simple option assignments to be placed before imports.
You mean that the ORDER
rule, which equals to the Google Style Guide, should allow a few exceptions about option and import in some situations, rather than forcing end-users to turn entire off.
Is my understanding correct?
from protolint.
Related Issues (20)
- Stray double semi-colon cause erratic results
- protolint npm package isn't available HOT 3
- Error thrown when installing protolint through yarn HOT 1
- Can't read Unix domain socket as a file
- FILE_NAMES_LOWER_SNAKE_CASE fails to convert kebab case to snake case HOT 2
- RPC_NAMES_UPPER_CAMEL_CASE disable is ignored HOT 1
- Some rules do not support auto-disable HOT 5
- Allow exclusion list of field names for `FIELDS_HAVE_COMMENT` HOT 1
- ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH failing even with `allow_alias = true` HOT 1
- CVEs in the latest version HOT 2
- Create folder for reporting output file
- Using config_path plugin parameter does not work
- panic in `protolint --fix`
- Json Report Enhancements HOT 3
- Configure rule severity via protolint config HOT 1
- Configuring severity does not work for MaxLineLengthRule HOT 1
- Rule for first value of enum should have numeric value zero? HOT 3
- Bug: Missing 'new' in https://github.com/yoheimuta/protolint/blob/master/bdist/js/install.mjs HOT 4
- please fix license inconsistency HOT 1
- Exit with 0 when -fix is enabled and the files to lint only contain fixable issues HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from protolint.