Pass result of run() to afterRun() in yii\base\Action? about yii-core HOT 6 CLOSED

Sounds reasonable for 2.1 but I'd go a bit further by passing result through allowing to post-process it:

return $this->afterRun($result);

Can't be done in 2.0 because of method signature change.

from yii-core.

Sorry) I'm talking about this piece of code here https://github.com/yiisoft/yii2/blob/master/framework/base/Action.php#L94-L95

public function runWithParams($params)
{
	...
	if ($this->beforeRun()) {
		$result = call_user_func_array([$this, 'run'], $args);
		$this->afterRun();
		return $result;
	}
	...
}

Wouldn't it be right to pass $result to afterRun() before returning it? Like this:

	...
	if ($this->beforeRun()) {
		$result = call_user_func_array([$this, 'run'], $args);
		$this->afterRun($result);
		return $result;
	}
	...

To be able to analyze the result of the action in afterRun() and change afterRun()'s execution accordingly. Right now I came up with a solution where I pass stuff through action class parameters. But it just seems not right. Or maybe I'm wrong, that was the base question) Is it worth making a PR or even talking about?

An example: action class which sends some specific EventSource stuff to the browser before and after each action.

class Operation extends \yii\base\Action
{
	...
	protected function beforeRun()
	{
		\Yii::$app->getLog()->targets['operation']->rotateFiles();
		$this->log('Operation begin [' . date('Y-m-d H:i:s') . ']');
		EventSource::begin();
		return true;
	}

	protected function afterRun()
	{
		... this is where it would be nice to have action run result to change $data ...
		EventSource::end($data);
		$this->log('Operation end [' . date('Y-m-d H:i:s') . ']');
	}
	...
}

from yii-core.

Sorry I read your message three times but I do not get what you are asking :) Could you rephrase or explain in more detail please?

from yii-core.

Thanks for posting in our issue tracker.
In order to properly assist you, we need additional information:

• When does the issue occur?
• What do you see?
• What was the expected result?
• Can you supply us with a stacktrace? (optional)
• Do you have exact code to reproduce it? Maybe a PHPUnit tests that fails? (optional)

Thanks!

This is an automated comment, triggered by adding the label status:need more info.

from yii-core.

+1
I think it's reasonable to pass the result to afterRun

With out the result of run() to be passed to afterRun, afterRun can do very few things.

from yii-core.

The issue doesn't apply to new code anymore.

from yii-core.