Git Product home page Git Product logo

Comments (25)

a-tonchev avatar a-tonchev commented on May 24, 2024 1

I made here video how it looks like:

https://vimeo.com/570653523

I think maybe a double tap or 2-finger zoom control would be better than the native behavior :)

from react-gallery-carousel.

yifaneye avatar yifaneye commented on May 24, 2024 1

@AnmolChhabra98
Thanks for the information! I think I have found the issue. I will fix it in the next release!

from react-gallery-carousel.

AnmolChhabra98 avatar AnmolChhabra98 commented on May 24, 2024 1

@yifaneye That's great news πŸ‘.

from react-gallery-carousel.

yifaneye avatar yifaneye commented on May 24, 2024 1

@AnmolChhabra98 @a-tonchev I have followed the steps mentioned. It works on my iPhone X. I will try it when I go to the electronics store.

from react-gallery-carousel.

yifaneye avatar yifaneye commented on May 24, 2024

Hi @a-tonchev ! Thank you for raising this issue up! πŸ˜„

I tried to duplicate this issue but cannot duplicate the behaviour that you had, as if I double-tap the image in full-screen mode it does not have a zoom-in effect. Would you like to tell me which browser and OS you used and their respective version, please? Thanks! πŸ˜€

from react-gallery-carousel.

a-tonchev avatar a-tonchev commented on May 24, 2024

Hi @yifaneye can you try to zoom with 2 fingers? I have xiaomi pocophone, tried on mobile chrome.

from react-gallery-carousel.

yifaneye avatar yifaneye commented on May 24, 2024

Hi @a-tonchev , I did try to zoom with 2 fingers, as well as, double-tap. However, I can not replicate this issue. Thank you for providing me with this information! I will keep investigating.

from react-gallery-carousel.

yifaneye avatar yifaneye commented on May 24, 2024

Hi @a-tonchev , thanks for the video! I can see that you experienced this issue on your device. I will try to get it fixed.

from react-gallery-carousel.

AnmolChhabra98 avatar AnmolChhabra98 commented on May 24, 2024

Hi @yifaneye , @a-tonchev
I have experienced the same issue. Is this fixed in this new version ?

from react-gallery-carousel.

yifaneye avatar yifaneye commented on May 24, 2024

Hi @AnmolChhabra98 ,
I can't replicate the issue. Would you like to give me more information?

from react-gallery-carousel.

a-tonchev avatar a-tonchev commented on May 24, 2024

@yifaneye maybe you can use something similar like https://manuelstofer.github.io/pinchzoom/

But I am not sure if pinchzoom is the best choice

from react-gallery-carousel.

yifaneye avatar yifaneye commented on May 24, 2024

Thanks @a-tonchev. I will have a look!

from react-gallery-carousel.

AnmolChhabra98 avatar AnmolChhabra98 commented on May 24, 2024

@yifaneye Sorry for replying late. You can try these steps to reproduce:-

  1. Zoom any image.
  2. Zoom out from the image.
  3. Try to move to the next image (& you are unable to move to the next image).

Or for more clarity, you can have a look at the video mentioned by @a-tonchev.

I have experienced it on a mobile device and I am using user-managed slides.

from react-gallery-carousel.

yifaneye avatar yifaneye commented on May 24, 2024

This issue is now fixed in v0.2.6.

from react-gallery-carousel.

AnmolChhabra98 avatar AnmolChhabra98 commented on May 24, 2024

Thanks, @yifaneye for this release but this isn't working as expected. I have tested it on my mobile device it is not moving to the next or previous slide after zoom.

from react-gallery-carousel.

yifaneye avatar yifaneye commented on May 24, 2024

Hi @AnmolChhabra98 ! Can this be a problem of the device? Would you like to debug for me, please?

from react-gallery-carousel.

yifaneye avatar yifaneye commented on May 24, 2024

Would you like to tell me what mobile device did you use? I will try it when I go to the electronics store. 😁

from react-gallery-carousel.

a-tonchev avatar a-tonchev commented on May 24, 2024

@yifaneye you can open full screen mode and try to zoom in and out with 2 fingers. After that try to slide with the finger again (not with the arrow) I get this issue on all devices home :) Iphone 4, Pocophone f1, Samsung Galaxy Tab s7+

from react-gallery-carousel.

AnmolChhabra98 avatar AnmolChhabra98 commented on May 24, 2024

Hi @yifaneye, @a-tonchev, I have also tested on various mobile device but it is still the same. I have tested it on.
-> Realme X
-> Vivo v17, etc.

from react-gallery-carousel.

AnmolChhabra98 avatar AnmolChhabra98 commented on May 24, 2024

@yifaneye, Are you following the same steps as mentioned in just above comment by @a-tonchev ?

from react-gallery-carousel.

yifaneye avatar yifaneye commented on May 24, 2024

Hi @AnmolChhabra98 @a-tonchev, I have fixed the issue using my friend's Samsung phone. Would you like to check it for me please?

from react-gallery-carousel.

AnmolChhabra98 avatar AnmolChhabra98 commented on May 24, 2024

Hi @yifaneye, Sorry for the late reply. I have tested the new release on my mobile device and it working perfectly,
Thank you so much for fixing this😊.

from react-gallery-carousel.

yifaneye avatar yifaneye commented on May 24, 2024

Hi @AnmolChhabra98 ! No worries. Great news! It's my pleasure. πŸ˜„

from react-gallery-carousel.

a-tonchev avatar a-tonchev commented on May 24, 2024

@yifaneye for me also it works great, thanks :)

from react-gallery-carousel.

yifaneye avatar yifaneye commented on May 24, 2024

Hi @a-tonchev ! No worries. Great news! It's my pleasure. 😁

from react-gallery-carousel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.