Git Product home page Git Product logo

Comments (6)

yifaneye avatar yifaneye commented on May 24, 2024

Hi @rohantarai ! Thank you for raising this issue up! 😄

Thank you for your appreciation! I will add support for video files and publish a new version before the end of next week. 👨🏻‍💻 Rest assured that there will be no breaking changes. I will notify you for the new version.

from react-gallery-carousel.

rohantarai avatar rohantarai commented on May 24, 2024

Hey @yifaneye ,
Thanks for responding to my request. i am happy to see that you accepted it as an enhancement. Looking forward to use the video feature! :)

from react-gallery-carousel.

yifaneye avatar yifaneye commented on May 24, 2024

Hi @rohantarai ,
You're welcome! You will see the video feature before the end of next week.

from react-gallery-carousel.

yifaneye avatar yifaneye commented on May 24, 2024

Hi @rohantarai ,

Issue #27 reminded me that you can use the "children" prop for placing video files into the carousel. Currently, the "children" prop is served as an option for "user-managed" slides. Since I believe that developer users may have their own markup and styles to be placed in each slide.

For example, you can place your video file here to replace the text in the slide

Hope it helps!

from react-gallery-carousel.

rohantarai avatar rohantarai commented on May 24, 2024

@yifaneye Hey sorry for late reply. As in the documentation it was not mentioned about using children prop to show video files, so i thought to tell you about adding feature for video files.

from react-gallery-carousel.

yifaneye avatar yifaneye commented on May 24, 2024

Hi @rohantarai !

Thank you for pointing this out! You asked a very good question. 😀

I will enhance the documentation to mention about "using children prop to show video files".

from react-gallery-carousel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.