Git Product home page Git Product logo

Comments (3)

ygoe avatar ygoe commented on May 20, 2024

Unfortunately I have no idea about web workers. This answer suggests that your suggested code change won't work very well. And I couldn't find out what that self is. I'll leave this open until somebody provides a reliable alternative.

from msgpack.js.

ShenTengTu avatar ShenTengTu commented on May 20, 2024

In the script of Web Workers, the self property returns WorkerGlobalScope object (the Worker global scope).

WorkerGlobalScope - Web APIs | MDN

I reference the solution from the other library:

  // Environment detection
  if (
    typeof module === "object" && module && typeof module.exports === "object"
  ) {
    // Node.js
    module.exports = msgpack;
  } else {
    // Global object
    var g;
    if (typeof window !== "undefined") {
      g = window;
    } else if (typeof global !== "undefined") {
      g = global;
    } else if (typeof self !== "undefined") {
      g = self;
    } else {
      g = this;
    }
    g[g.msgpackJsName || "msgpack"] = msgpack;
  }

from msgpack.js.

darcyparker avatar darcyparker commented on May 20, 2024

https://caniuse.com/?search=globalThis
https://mathiasbynens.be/notes/globalthis has discussion on polyfills

Based on the above, pass the globalThis into your IIFE like this:

(function (_global) { //bind globalThis to _global
...
	// Environment detection
	if (typeof module === "object" && module && typeof module.exports === "object") {
		// Node.js
		module.exports = msgpack;
	}
	else if (_global) {
		// Global object
		_global[_global.msgpackJsName || "msgpack"] = msgpack;
	}
)(globalThis || this || self || window);

Notes:

  • Assumes no one bound something unexpected to globalThis from the context you call the IIFE.
  • In most modern JS environments globalThis will be defined and that's what will be used
  • If the JS environment is older, first fallback is this.
    • There are edge cases where this is not defined, so the next fallbacks are self || window
    • There are edge cases where self || window is undefined... or someone could have done var self=something so first fallback is this.
    • It is possible someone imported or called your IIFE from something other than the global context. But is this likely? I can't imagine any use case where someone would do this...
  • Finally, if this was undefined from the context msgpack.js was imported, the fallbacks self || window will work if some unexpected value wasn't bound to them. It's a risk that someone may have defined var self=something in the context of the import, but it would be unusual; especially if the previous globalThis and this were not defined.

There won't be any perfect solution to polyfill globalThis... but this is decent I think.

Another option is to not define global.mspack. and instead just support commonJS and expect browsers to use an applicable module loader that supports commonjs.

from msgpack.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.