Comments (2)
I'm pretty sure this is an artifact of the pre-commit
engine, rather than our library. These are the reasons why I believe so:
1. We only output after all files are scanned
Source:
We only output this per invocation of the pre-commit hook, based on the list of filenames that are given to us. While we may be able to perform the logic to get the git diff --staged --name-only
files, this would be essentially monkey-patching the pre-commit
engine? It might work, seeing that we scan all files anyway, but it also seems like an anti-pattern.
2. Pre-commit performs xargs optimizations for parallel processing
Stack trace:
- https://github.com/pre-commit/pre-commit/blob/b8300268bf2d8797f28edf9063d7e5659ad4d535/pre_commit/commands/run.py#L123-L125
- https://github.com/pre-commit/pre-commit/blob/b8300268bf2d8797f28edf9063d7e5659ad4d535/pre_commit/repository.py#L100
- https://github.com/pre-commit/pre-commit/blob/809b7482df7b739014cb583c0793f495d9a949d0/pre_commit/languages/python.py#L148
- https://github.com/pre-commit/pre-commit/blob/9c6a1d80d6b94c86a1785a40a51389e83accac3e/pre_commit/languages/helpers.py#L90
- https://github.com/pre-commit/pre-commit/blob/9c6a1d80d6b94c86a1785a40a51389e83accac3e/pre_commit/xargs.py#L89
Essentially, this suggests that pre-commit
does invoke our library multiple times, hence printing multiple statements.
I'll leave this issue open for discussions around whether performing the git diff
ourselves is worth it; otherwise, my recommendation is to close this as "Won't Do" for the above reasons.
from detect-secrets.
We're going to close this issue as it hasn't received any update in a very long time. Feel free to re-open it if you think it's still relevant.
from detect-secrets.
Related Issues (20)
- Fix README so copy/paste works HOT 1
- Supported languages? HOT 3
- Secret followed by type hint are not detected
- Secrets are not found in Jupyter Notebooks HOT 1
- validity checking of detected secrets ? HOT 5
- Detect a npmrc auth token being checked in HOT 1
- Problem with Python3.11 and pre-commit HOT 4
- False Negative - YAML Parser Stops Reading After First String Value/Does Not Read Lists of Strings
- Getting detect-secrets: command not found error HOT 3
- Request: using a baseline as an allowlist HOT 5
- Pre-commit hook fails with "error: Unable to read baseline." HOT 1
- Reddit HOT 1
- Request: Push a new tag HOT 3
- Bug file with just `APEOptState` seems to be breaking `detect-secrets[word_list]==1.5.0` HOT 1
- detect-secrets-hook read file list from a file, to allow use of exit code HOT 2
- KeywordDetector plugin doesn't detect secrets which start with a symbol
- Configure to only warn, for pre-commit hook config HOT 5
- Bypass any plugin with square brackets HOT 2
- detect-secrets not identifying all Github token occurrences in a file
- very slow processing speed for lines with a large number of consecutive spaces
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from detect-secrets.