PsByFlag is not tested about takes HOT 16 CLOSED

@yegor256 right, I added the bug tag

from takes.

@yegor256 thanks for the report, I topped your acc for 15 mins, payment ID 000-02320972

from takes.

@ikhvostenkov it's yours now, please proceed keeping in mind our principles. Feel free to ask any technical questions right here in the ticket... The budget of this issue is 30 mins, which is exactly how much will be paid when the task is done (see this for explanation)

from takes.

@davvd I've done with the test. I have 3 questions:

1. Do you have any coding rules convention doc? I was trying to follow coding rules in other tests, but could be not perfect.
2. JUnit is absent in pom.xml. Tests will not run without this dependency. I do not understand how it works for instance on building machine. I've just added dependency locally in my IDE to run it.
3. Shall I open pull request with my changes?

from takes.

One more point: actually test was already created and covered ~60%, I've modified it to reach 100% coverage.

from takes.

@ikhvostenkov just run mvn clean install -Pqulice on command line and you will see our coding conventions (we use qulice.com for that). JUnit is coming from parent pom, see http://www.yegor256.com/2015/02/05/jcabi-parent-maven-pom.html

Yes, just submit a pull request when you're ready, see http://www.yegor256.com/2014/04/15/github-guidelines.html

from takes.

@ikhvostenkov the task is your hands for the last 15 days.. keep in mind that if it's not closed in the next 48 hours, it will be re-assigned to someone else, see No Obligations principle. This article should help if you're stuck. -30 added to your rating, at the moment it is: +0

from takes.

@yegor256 Could you please close it if you do not have any comments, due to pull request has been successfully merged?

from takes.

@ikhvostenkov many thanks!

from takes.

@elenavolokhova please, review this ticket for compliance with our QA rules

from takes.

@ikhvostenkov

ikhvostenkov commented 24 days ago
One more point: actually test was already created and covered ~60%, I've modified it to reach 100% coverage.

According to our quality rules:

Messages in a ticket always start with a name of a user they are addressed to.

Try to avoid such issues in future.

Please confirm that everything is clear and you have no questions regarding this approach.

from takes.

@elenavolokhova confirmed. Everything is absolutely clear.

from takes.

@ikhvostenkov Thank you.

from takes.

@davvd Quality is acceptable.

from takes.

@davvd Quality is acceptable.

@elenavolokhova thanks, got it. everybody, please try to make it good next time

from takes.

@ikhvostenkov 10 mins was added to the account of @elenavolokhova (for QA review), in transaction 55871054... thank you, added 38 mins to your acc, payment num is 55871122, 496 hours and 59 mins spent in total to complete... the bonus for fast delivery (age=3853)... +38 to your rating, your total score is +61

from takes.