PDD-3FBB12D7-11: PMD validator doesn't work about qulice HOT 20 CLOSED

migrated from Trac, where originally posted by yegor256 on 24-Oct-2011 8:02pm

Dmitry, can you help with this ticket?

from qulice.

migrated from Trac, where originally posted by dmitry.bashkin on 24-Oct-2011 8:41pm

I shall try:)

from qulice.

migrated from Trac, where originally posted by dmitry.bashkin on 5-Nov-2011 5:24pm

In [269/qulice]:

#CommitTicketReference repository="qulice" revision="269"
refs #20 - new branch

from qulice.

migrated from Trac, where originally posted by dmitry.bashkin on 8-Nov-2011 2:11pm

In [276/qulice]:

#CommitTicketReference repository="qulice" revision="276"
refs #20 - done.

from qulice.

migrated from Trac, where originally posted by dmitry.bashkin on 8-Nov-2011 2:16pm

In [277/qulice]:

#CommitTicketReference repository="qulice" revision="277"
refs #20 - sync with trunk

from qulice.

migrated from Trac, where originally posted by dmitry.bashkin on 8-Nov-2011 2:24pm

This was the last ticket assigned to me. I need more :)

from qulice.

migrated from Trac, where originally posted by yegor256 on 8-Nov-2011 3:03pm

There are two places in your code where you're doing exception swallowing. It's a very bad practice. You should re-throw exception instead, wrapping it up into IllegalArgumentException. Logger.error() is not an option when there is a problem in the code. We should fail, not report a problem in log. Read about fail fast principle.

from qulice.

migrated from Trac, where originally posted by dmitry.bashkin on 9-Nov-2011 8:09am

In [278/qulice]:

#CommitTicketReference repository="qulice" revision="278"
refs #20 - exception throwing fixed.

from qulice.

migrated from Trac, where originally posted by dmitry.bashkin on 9-Nov-2011 8:10am

In [279/qulice]:

#CommitTicketReference repository="qulice" revision="279"
refs #20 - sync with trunk

from qulice.

migrated from Trac, where originally posted by dmitry.bashkin on 9-Nov-2011 8:12am

I fixed it, but it began throwing IllegalArgumentExceptions while validating some files from maven-plugin.

from qulice.

migrated from Trac, where originally posted by yegor256 on 9-Nov-2011 2:40pm

I see. Let me know if you need any help.

from qulice.

migrated from Trac, where originally posted by dmitry.bashkin on 9-Nov-2011 8:29pm

In [285/qulice]:

#CommitTicketReference repository="qulice" revision="285"
refs #20 - complete.

from qulice.

migrated from Trac, where originally posted by dmitry.bashkin on 9-Nov-2011 8:32pm

In [286/qulice]:

#CommitTicketReference repository="qulice" revision="286"
refs #20 - sync with trunk

from qulice.

migrated from Trac, where originally posted by yegor256 on 11-Nov-2011 5:07pm

Cool, let's try to merge...

from qulice.

migrated from Trac, where originally posted by guard on 11-Nov-2011 5:17pm

In [287/qulice]:

#CommitTicketReference repository="qulice" revision="287"
refs #20 - /branches/ticket20 merged into /trunk, 2 hours spent

from qulice.

migrated from Trac, where originally posted by guard on 11-Nov-2011 5:18pm

In [288/qulice]:

#CommitTicketReference repository="qulice" revision="288"
refs #20 - /branches/ticket20 successfully closed

from qulice.

migrated from Trac, where originally posted by yegor256 on 11-Nov-2011 5:50pm

Thanks!

from qulice.

migrated from Trac, where originally posted by yegor256 on 13-Nov-2011 12:09pm

Take a look at the changes I've made in r290. Now code looks more compact and clean.

from qulice.

migrated from Trac, where originally posted by yegor256 on 22-Jan-2012 11:39pm

Milestone PROTOTYPE deleted

from qulice.

migrated from Trac, where originally posted by yegor on 21-Apr-2013 12:03pm

we moved to Github

from qulice.