checkstyle check: prohibit string literals concatenation about qulice HOT 23 CLOSED

migrated from Trac, where originally posted by yegor256 on 18-Oct-2011 5:38pm

Dzmitry, this ticket is for you. Let's discuss first, if you have questions.

from qulice.

migrated from Trac, where originally posted by yegor256 on 18-Oct-2011 7:01pm

BTW, I'm not sure whether it should be a checkstyle or PMD check. It's up to you.

from qulice.

migrated from Trac, where originally posted by dpetruha on 18-Oct-2011 8:19pm

Should we exclude Java comments for checks? I.e. code like this is supposed to be correct, right?:

// String a = "done in " + time + " seconds";

from qulice.

migrated from Trac, where originally posted by yegor256 on 18-Oct-2011 8:37pm

Yeah, of course. We should complain only about real java code. I think that checkstyle provides you this information. We shouldn't treat .java files as texts. Instead, we should rely on checkstyle existing mechanisms (getDefaultTokens(), visitTokens(), etc). For example: [source:/trunk/qulice/qulice-checkstyle/src/main/java/com/qulice/checkstyle/JavadocTagsCheck.java@92]

ps. Don't forget to re-assign the ticket back to me when you need my attention or an answer

from qulice.

migrated from Trac, where originally posted by yegor256 on 1-Nov-2011 10:10pm

What is the status here?

from qulice.

migrated from Trac, where originally posted by yegor256 on 1-Nov-2011 10:11pm

Take a look at this ticket: #29. It is a bit similar. Maybe it will help.

from qulice.

migrated from Trac, where originally posted by dpetruha on 2-Nov-2011 12:58pm

Finally got to it, thank you for example!

from qulice.

migrated from Trac, where originally posted by dpetruha on 2-Nov-2011 1:03pm

In [233/qulice]:

#CommitTicketReference repository="qulice" revision="233"
refs #18 - new branch

from qulice.

migrated from Trac, where originally posted by dpetruha on 2-Nov-2011 5:39pm

In [236/qulice]:

#CommitTicketReference repository="qulice" revision="236"
refs #18 - done

from qulice.

migrated from Trac, where originally posted by dpetruha on 2-Nov-2011 5:42pm

done

from qulice.

migrated from Trac, where originally posted by dpetruha on 2-Nov-2011 5:43pm

sorry, slight fix needed)

from qulice.

migrated from Trac, where originally posted by yegor256 on 2-Nov-2011 5:46pm

Don't forget to run mvn -Dci verify before returning the ticket back

from qulice.

migrated from Trac, where originally posted by dpetruha on 2-Nov-2011 5:47pm

In [237/qulice]:

#CommitTicketReference repository="qulice" revision="237"
refs #18 - error message added

from qulice.

migrated from Trac, where originally posted by dpetruha on 2-Nov-2011 5:49pm

done now I guess

from qulice.

migrated from Trac, where originally posted by yegor256 on 2-Nov-2011 5:52pm

Try to test with mvn -Dci verify, you will see how many formatting problems it has (even difficult to review the implementation because of them). Please, fix them and I will try to merge the branch into trunk.

from qulice.

migrated from Trac, where originally posted by dpetruha on 2-Nov-2011 11:33pm

In [238/qulice]:

#CommitTicketReference repository="qulice" revision="238"
refs #18 - checkstyle fixes

from qulice.

migrated from Trac, where originally posted by dpetruha on 2-Nov-2011 11:35pm

done

from qulice.

migrated from Trac, where originally posted by yegor256 on 3-Nov-2011 6:25am

Looks good, let me try to merge...

from qulice.

migrated from Trac, where originally posted by guard on 3-Nov-2011 6:35am

In [239/qulice]:

#CommitTicketReference repository="qulice" revision="239"
refs #18 - /branches/ticket18 merged into /trunk, 1 hours spent

from qulice.

migrated from Trac, where originally posted by guard on 3-Nov-2011 6:36am

In [240/qulice]:

#CommitTicketReference repository="qulice" revision="240"
refs #18 - /branches/ticket18 successfully closed

from qulice.

migrated from Trac, where originally posted by yegor256 on 3-Nov-2011 6:47am

Good job, many thanks!

from qulice.

migrated from Trac, where originally posted by yegor256 on 22-Jan-2012 11:39pm

Milestone PROTOTYPE deleted

from qulice.

migrated from Trac, where originally posted by yegor on 21-Apr-2013 12:03pm

we moved to Github

from qulice.