to implement db->mysql->version->atLeast(...) about phprack HOT 8 OPEN

migrated from Trac, where originally posted by yegor256 on 12-Apr-2010 12:44pm

can you implement this in 1 hour? if yes, please go ahead

from phprack.

migrated from Trac, where originally posted by j.derda on 12-Apr-2010 8:00pm

Ok, but please list all possible conditions. So far I can think of:
-atLeast
-equal
-newer (moreThan? or both, with one as alias?)
-stable (like no alpha or beta in name?)

• I assume we should properly handle '*'

from phprack.

migrated from Trac, where originally posted by yegor256 on 12-Apr-2010 8:08pm

let's do it for atLeast() now, that's enough. later we will try to implement others. so far, only atLeast() is interested.

from phprack.

migrated from Trac, where originally posted by j.derda on 14-Apr-2010 9:30pm

implemented in r392 and r393

from phprack.

migrated from Trac, where originally posted by yegor256 on 14-Apr-2010 9:52pm

the design has two major flaws:

• we should never have public properties in classes
• version of the database can't be FALSE, it's an old C-style

you should introduce a new package phpRack_Package_Db_Mysql_Version, and getVersion() should throw an exception if the adapter is not connected to DB.

from phprack.

migrated from Trac, where originally posted by anonymous on 23-Apr-2010 12:18am

Some changes commited in r437. However I have a problem that I don't know how to access particular db instance in phpRack_Package_Db_Mysql_Version constructor - I've left a todo mark, please review the code and let me know how db instance should be accessed

from phprack.

migrated from Trac, where originally posted by yegor256 on 23-Apr-2010 7:15am

Looks better, but @todo tags should be properly formatted before I can merge your branch with trunk (see PDD concept). And your branch should not break the trunk, after merging into it. Please, review the branch, fix the tags and make sure that the branch is "buildable".

All questions, concerns, ideas should be explained in @todo tags, and in code.

from phprack.

migrated from Trac, where originally posted by yegor256 on 7-May-2010 4:59am

Any news here?

from phprack.