Comments (8)
migrated from Trac, where originally posted by yegor256 on 12-Apr-2010 12:44pm
can you implement this in 1 hour? if yes, please go ahead
from phprack.
migrated from Trac, where originally posted by j.derda on 12-Apr-2010 8:00pm
Ok, but please list all possible conditions. So far I can think of:
-atLeast
-equal
-newer (moreThan? or both, with one as alias?)
-stable (like no alpha or beta in name?)
- I assume we should properly handle '*'
from phprack.
migrated from Trac, where originally posted by yegor256 on 12-Apr-2010 8:08pm
let's do it for atLeast()
now, that's enough. later we will try to implement others. so far, only atLeast()
is interested.
from phprack.
migrated from Trac, where originally posted by j.derda on 14-Apr-2010 9:30pm
implemented in r392 and r393
from phprack.
migrated from Trac, where originally posted by yegor256 on 14-Apr-2010 9:52pm
the design has two major flaws:
- we should never have public properties in classes
- version of the database can't be
FALSE
, it's an old C-style
you should introduce a new package phpRack_Package_Db_Mysql_Version
, and getVersion()
should throw an exception if the adapter is not connected to DB.
from phprack.
migrated from Trac, where originally posted by anonymous on 23-Apr-2010 12:18am
Some changes commited in r437. However I have a problem that I don't know how to access particular db instance in phpRack_Package_Db_Mysql_Version constructor - I've left a todo mark, please review the code and let me know how db instance should be accessed
from phprack.
migrated from Trac, where originally posted by yegor256 on 23-Apr-2010 7:15am
Looks better, but @todo
tags should be properly formatted before I can merge your branch with trunk (see PDD concept). And your branch should not break the trunk, after merging into it. Please, review the branch, fix the tags and make sure that the branch is "buildable".
All questions, concerns, ideas should be explained in @todo tags, and in code.
from phprack.
migrated from Trac, where originally posted by yegor256 on 7-May-2010 4:59am
Any news here?
from phprack.
Related Issues (20)
- problem with php->ini('memory_limit')->atLeast() assert HOT 3
- invalid version string in composer.json HOT 1
- automate ci HOT 36
- composer cannot find v1.1 phprack distribution HOT 7
- Estimate project size HOT 1
- 1.2 HOT 3
- Indie tech review no.1 HOT 1
- Database check returns Failure even on success, HOT 2
- Dependency Dashboard
- Port to PHP 5.3 Namespaces HOT 1
- Security issue with passing test filename. HOT 5
- testsTotal parameter not working as expected for the list of scenarios. HOT 6
- Default value for $pattern in the method phpRack_Package_Network_Url->regex($pattern) HOT 2
- Function to construct Test Url HOT 1
- phpRack_Runner->getTestURL() problem with generation of the link. HOT 3
- success() and fail() functions do not interrupt the test. HOT 1
- Fatal error if method does not exists in the assertion class. HOT 1
- Test method to check response status of http request. HOT 1
- phpRack_Package_Php_LintTest->testLintExcludeOption() HOT 1
- Vagrant configuration
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phprack.