Git Product home page Git Product logo

Comments (1)

asmyasnikov avatar asmyasnikov commented on July 4, 2024

Struct database.sql.Rows returned bool
But implementation of interface database.sql.driver.RowsNextResultSet in database/sql obliges returns error.
This change is strictly major change. We have a few usages of v3 ydb-go-sdk now. Because v2 is a primarily recomendation now. It allows make this major change as minor without up of major version.
But this change obliges fixes client-side code
Current usages:

  1. read sing result:
if res.NextResultSet(ctx, "col1", "col2") && res.NextRow() {
   var (
     col1 string
     col2 uint64
   )
   err = res.Scan(&col1, &col2)
   if err != nil {
      // process err
   }
   // doing something with col1 and col2
}
  1. read all results:
for res.NextResultSet(ctx, "col1", "col2") {
   for res.NextRow() {
      var (
        col1 string
        col2 uint64
      )
      err = res.Scan(&col1, &col2)
      if err != nil {
         // process err
      }
      // doing something with col1 and col2
   }
}

After accept this change client code should be like this

  1. read single result
switch err = res.NextResultSet(ctx, "col1", "col2"); {
   case io.EOF:
      return
   case nil:
      if res.NextRow() {
         var (
           col1 string
           col2 uint64
         )
         err = res.Scan(&col1, &col2)
         if err != nil {
            // process err
         }
         // doing something with col1 and col2
      }
   default:
      // process unknown err
}
  1. read all results
for err = nil; err = res.NextResultSet(ctx, "col1", "col2"); err == nil {
  for res.NextRow() {
     var (
       col1 string
       col2 uint64
     )
     err = res.Scan(&col1, &col2)
     if err != nil {
        // process err
     }
     // doing something with col1 and col2
  }
}

And user should be check res.Err() after reading results just like before
But scale of consequences of non-checking res.Err() will be less them current consequences

from ydb-go-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.