Git Product home page Git Product logo

Comments (3)

yairEO avatar yairEO commented on August 12, 2024 1

yes you are correct. fixing now.
I actually had another version of this, where I fixed it already, but never pushed to github

from validator.

yairEO avatar yairEO commented on August 12, 2024

could you please clarify what do you mean by "skipped field"? what is the flow here

from validator.

tiomno avatar tiomno commented on August 12, 2024

By "skipped field" I mean a field that is not validated because is disabled, for instance.

In line 405 the method checkField return { valid:true, error:"" }.
I think it should be the same in line 411, it should return { valid:true, error:"" } instead of return {}; for consistency. If I have a code that checks the returned object it will fail if gets an empty object.

from validator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.