Opera does not support point-events about photobox HOT 10 CLOSED

Opera has no user base (3.38%), and also Opera will be moving to use the Webkit engine very soon, so things will start to actually work without needing to change any code. further more, I have no need

from photobox.

Right, but what I am saying is we shouldn't be doing browser sniffing, but feature detection instead (it's pretty simple: https://github.com/Modernizr/Modernizr/blob/master/feature-detects/css/pointerevents.js).

var supportsCSSPointerEvents = (function(){ var el = doc.createElement('x'); el.style.cssText = 'pointer-events:auto'; return el.style.pointerEvents === 'auto'})()

While Opera is less than 5% and will be upgraded soon, who knows what other browsers break.

Please note that this bug is fatal for those browsers, because nothing on the page is clickable.

Should I submit a pull request then do to feature detection?

from photobox.

there is absolutely no sniffing in the code..

from photobox.

what I mean is isIE should really just test for supportsPointerEvents

from photobox.

but my code is much better, I don't see why I should change it. it is the ultimate tester for IE. since IE never ever changes (no automatic updates) then this will always work

from photobox.

because what that check is doing is not IE specific, but in fact applies to all browsers that do not support pointer-events (opera, legacy android, etc)

from photobox.

I mean, like this: https://github.com/yairEO/photobox/pull/33/files

from photobox.

ho, I understand

from photobox.

pushed the change. I've change the code just a bit but it's almost the same

from photobox.

nice

from photobox.