Comments (10)
Opera has no user base (3.38%), and also Opera will be moving to use the Webkit engine very soon, so things will start to actually work without needing to change any code. further more, I have no need
from photobox.
Right, but what I am saying is we shouldn't be doing browser sniffing, but feature detection instead (it's pretty simple: https://github.com/Modernizr/Modernizr/blob/master/feature-detects/css/pointerevents.js).
var supportsCSSPointerEvents = (function(){ var el = doc.createElement('x'); el.style.cssText = 'pointer-events:auto'; return el.style.pointerEvents === 'auto'})()
While Opera is less than 5% and will be upgraded soon, who knows what other browsers break.
Please note that this bug is fatal for those browsers, because nothing on the page is clickable.
Should I submit a pull request then do to feature detection?
from photobox.
there is absolutely no sniffing in the code..
from photobox.
what I mean is isIE
should really just test for supportsPointerEvents
from photobox.
but my code is much better, I don't see why I should change it. it is the ultimate tester for IE. since IE never ever changes (no automatic updates) then this will always work
from photobox.
because what that check is doing is not IE specific, but in fact applies to all browsers that do not support pointer-events (opera, legacy android, etc)
from photobox.
I mean, like this: https://github.com/yairEO/photobox/pull/33/files
from photobox.
ho, I understand
from photobox.
pushed the change. I've change the code just a bit but it's almost the same
from photobox.
nice
from photobox.
Related Issues (20)
- Modal doesn't appear HOT 1
- Zooming large pictures with quality loss HOT 1
- JQuery appending but not showing HOT 4
- image gallery - have you seen anything like this HOT 3
- Latest Jquery 3.1.1 HOT 4
- pbOverlay div avoids me click on IE10 HOT 1
- Fix for mobile zoom issues HOT 2
- Thumbs do not swipe on mobile HOT 5
- Mouse use
- The basic example doesn't work. HOT 1
- Image stuck on loading screen HOT 1
- Choose a License HOT 5
- help me to use it
- Photo orientation incorrect. HOT 1
- Trying to get the basics to work - fixed - sample code of page HOT 1
- Preview for huge files failing in Chrome HOT 1
- Can't get it to work on a bootstrap Page HOT 1
- Issue with reactjs ? HOT 3
- Please create a new release
- iphone issue for photobox gallery HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from photobox.