Git Product home page Git Product logo

Comments (5)

luisangelsm avatar luisangelsm commented on May 22, 2024 1

prs from forks are already fixed by skipping signing, but signing should also be skipped in forks p, otherwise CI fails when it tries to sign the macos binaries

from yacreader.

selmf avatar selmf commented on May 22, 2024

Actually this doesn't only break PRs coming from forks, it also breaks CI on forks.

from yacreader.

jeremydouglass avatar jeremydouglass commented on May 22, 2024

Doesn't that make sense? I'm not at all familiar with azure, but if I fork something on github, arbitrarily change it, and then build it, it should be unsigned -- I would think. Otherwise signing doesn't mean anything.

from yacreader.

selmf avatar selmf commented on May 22, 2024

This is more than just signing not working. Azure treats the whole pipeline as broken because the signature file isn't available. So it doesn't even build on my fork …

from yacreader.

selmf avatar selmf commented on May 22, 2024

If I'm not mistaken, @luisangelsm fixed this already.

from yacreader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.