Git Product home page Git Product logo

Comments (2)

peterkogo avatar peterkogo commented on June 11, 2024

@mcmxcdev You can just return true inside the onbeforedelete handler so the elements get deleted (false if deletion has not been confirmed). There is no need to actually programmatically delete the elements.

However, I still see you point. I assume there might be a reason to delete those elements programmatically, or to simply distinguish what has triggered the deletion (user input vs. program).

What do you think about an optional force parameter for deleteElements that skips onbeforedelete?

from xyflow.

mcmxcdev avatar mcmxcdev commented on June 11, 2024

It's not that we trigger an async request in onbeforedelete that needs to be awaited until it can be deleted. It's a modal window that might or might not confirm the deletion. So we are taken completely out of the flow of onbeforedelete, hence we need programatical deletion.

However, I still see you point. I assume there might be a reason to delete those elements programmatically, or to simply distinguish what has triggered the deletion (user input vs. program).

Yes, 100%

What do you think about an optional force parameter for deleteElements that skips onbeforedelete?

That would sound reasonable to fix the issue I am experiencing, but other users might run into situations where they would need event exposed for other use cases, so I would still consider that important.

from xyflow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.