Git Product home page Git Product logo

Comments (5)

xuset avatar xuset commented on August 25, 2024

In the service worker, after update() is called the old snapshots should be removed. This can be accomplished by retrieving the list of snapshots, getAllSnapshots(), and then calling remove() on those snapshots excluding the most recent snapshot.

from planktos.

georgeaf99 avatar georgeaf99 commented on August 25, 2024

@xuset @alvin319 Shouldn't this be handled in update? I thought we were looking to depreciate the snapshots interface from Planktos?

from planktos.

xuset avatar xuset commented on August 25, 2024

For it to be handled in update() the interface has to change first which seems out of scope for this issue

from planktos.

georgeaf99 avatar georgeaf99 commented on August 25, 2024

I'm not sure I see why the interface would have to change? The update function gets the latest snapshot, so it could just delete all the other ones after it finishes storing the new snapshot.

from planktos.

xuset avatar xuset commented on August 25, 2024

The existing interface doesn't make sense when there can only be one snapshot. getAllSnapshots and removeSnapshot are pointless when there is only one snapshot

from planktos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.