Invert colors on selection about xterm.js HOT 7 CLOSED

Something like this would certainly be a lot easier to implement if the colors were still set via javascript instead of CSS.

from xterm.js.

That's true, but I think the better solution to combine both is to use a preprosessor like SCSS.

from xterm.js.

Even with a preprocessor, if the consumer wants to support more themes than are available they need to write all the styles themselves. If this is considered a feature, they will have to write the ::selection rules.

You can see how I put this together with VS Code here, I could probably transform it into a theme addon relatively easily if that's preferable to adding it to xterm.js.

from xterm.js.

Eventually I am not sure about this. It could make the Terminal look quite weird.

Terminal.app just changes the background of the selection to gray. @Tyriar could you please provide us with a screenshot of how gnome-terminal handles this?

Terminal.app screenshot

from xterm.js.

It sets fg to bg and bg to fg when selected. The good thing about it is that it's just as readable as the original text.

from xterm.js.

I think I tend more towards improving the background highlighting. I think that bg/fg color inversion is not what most users are used to right now.

from xterm.js.

Closing in favor of #692

from xterm.js.