Git Product home page Git Product logo

Comments (7)

Tyriar avatar Tyriar commented on August 16, 2024 1

@gasper94 we've moved over to the @xterm scope so you want the modules @xterm/xterm and @xterm/addon-fit

from xterm.js.

gasper94 avatar gasper94 commented on August 16, 2024

build locally & vercel deployment

from xterm.js.

jerch avatar jerch commented on August 16, 2024

Can you describe, what that actually fixes? To me it seems, that you only commented out/widened TS types?

from xterm.js.

gasper94 avatar gasper94 commented on August 16, 2024

I was trying to deploy a project to vercel using xTerm and xterm-addon-fit().

I got this error build error (dev worked fine): 7:10 Error: FitAddon not found in 'xterm-addon-fit' import/named

I had the library "xterm-addon-fit": "^0.8.0" and import { FitAddon } from 'xterm-addon-fit';

I pointed the library to this: import { FitAddon } from 'xterm-addon-fit/src/FitAddon';

but on that file: browser/renderer/shared/Types is nowehere to be found

so, I removed that line and everything worked as spected. I was able to run and build. I'm I doing something wrong?

Untitled

from xterm.js.

Tyriar avatar Tyriar commented on August 16, 2024

You're pointing it to src/ which includes the typescript code. You are meant to use whatever main in the package.json points to:

"main": "lib/addon-fit.js",

Otherwise you have to deal with compiling the TS yourself which isn't possible without the rest of the core repo.

from xterm.js.

gasper94 avatar gasper94 commented on August 16, 2024

Totally. I understand that but when I point it to "main" I get this error (7:10 Error: FitAddon not found in 'xterm-addon-fit' import/named): I have xtermjs + xterm-addon-fit on node_modules.

from xterm.js.

gasper94 avatar gasper94 commented on August 16, 2024

Great!!! Thank you!

from xterm.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.