Git Product home page Git Product logo

Comments (5)

vitormv avatar vitormv commented on August 26, 2024 1

@xpl Samsung Internet only supports it after version 6.0. Version 5 was released in May 2017, it's not so old. Version 5 shipped with the Galaxy S8 for example. If user never updates the apps from the Galaxy Store, they will get the error. And that is only one browser/example, im sure there are many more use cases for being able to transpile the code.

Source: https://en.wikipedia.org/wiki/Samsung_Internet_for_Android

from es7-object-polyfill.

vitormv avatar vitormv commented on August 26, 2024 1

The use case here being, if we need to import this package, that means we are dealing with old browsers that need to be supported (its sad i know, but we have to do it). And usually packages inside node_modules/* are never compiled because they are expected to come already transpiled to older versions. So here i would have two choices:

  1. manually change webpack to explicitly compile this one folder inside node_modules
  2. or just copy/paste the polyfills from this library into my own src/polyfill.js file, so it gets compiled along with the application :)

For now, went with the 2nd, but would be nice to just import this polyfill and forget about it without any extra tweaks :)

from es7-object-polyfill.

xpl avatar xpl commented on August 26, 2024

@almaron Hello! May I ask why in 2019 you would need polyfilling Object.values or Object.entries? It has been supported for a long time in all major browsers natively:

Screen Shot 2019-03-20 at 13 28 11

from es7-object-polyfill.

xpl avatar xpl commented on August 26, 2024

@vitormv Thanks for the clarification!

Do you have any suggestion why does it fail, btw? I know that the minifier in popular frameworks fails when it sees some non-ES5 syntax, like classes (what a shame in 2019), but AFAIR there is none of such...

from es7-object-polyfill.

xpl avatar xpl commented on August 26, 2024

Fixed in ed3a161

Let me know if the issue with minification persists...

from es7-object-polyfill.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.